IETF Logo Mail Archive

Re: [quicwg/base-drafts] minimum valid packet size is an example (#4396)

David Schinazi <notifications@github.com> Fri, 20 November 2020 00:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C0303A1352 for <quic-issues@ietfa.amsl.com>; Thu, 19 Nov 2020 16:16:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IyAxeadichp1 for <quic-issues@ietfa.amsl.com>; Thu, 19 Nov 2020 16:16:40 -0800 (PST)
Received: from smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D32323A0E9B for <quic-issues@ietf.org>; Thu, 19 Nov 2020 16:16:40 -0800 (PST)
Received: from github.com (hubbernetes-node-a498e6d.ac4-iad.github.net [10.52.111.43]) by smtp.github.com (Postfix) with ESMTPA id 1F82852059D for <quic-issues@ietf.org>; Thu, 19 Nov 2020 16:16:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1605831400; bh=YAc9LXFPdQ4jYUK8ekTFgbWzGbSIbyaRtmHnJahQ07E=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Q0KtuyunB+ox5N+ggOGAQgTQO33H/YZygTepuAWaHONQn/7dfQ7dIJXdckgb5w7D+ zyypx78V9Y+FARIPE7+7wQyZf03a3wvEOkU29uUxBOjyD87kAlzamyMuNzQXSf746E XgP/wyibGgOEzuYF5SguWgI2SEPdDOm5pO3D9wg8=
Date: Thu, 19 Nov 2020 16:16:40 -0800
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYBBNLNNFOJ2CTOECN5YLV6REVBNHHCZBTWEA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4396/review/534982642@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4396@github.com>
References: <quicwg/base-drafts/pull/4396@github.com>
Subject: Re: [quicwg/base-drafts] minimum valid packet size is an example (#4396)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5fb70ae81c1c5_11a119b487324"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/21MWyVK-Innui6c3naiHpHz8nLA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2020 00:16:42 -0000

@DavidSchinazi commented on this pull request.



> @@ -3056,9 +3056,9 @@ An endpoint MUST NOT send a stateless reset that is three times or more larger
 than the packet it receives to avoid being used for amplification.
 {{reset-looping}} describes additional limits on stateless reset size.
 
-Endpoints MUST discard packets that are too small to be valid QUIC packets.
-With the set of AEAD functions defined in {{QUIC-TLS}}, packets that are smaller
-than 21 bytes are never valid.
+Endpoints MUST discard packets that are too small to be valid QUIC packets.  To
+give an example, with the set of AEAD functions defined in {{QUIC-TLS}}, short
+header packets that are smaller than 21 bytes are never valid.

I like this new text, but I think we need to be explicit about what the minimum length is for long headers (including VN).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4396#pullrequestreview-534982642

v2.23.0 | Report a Bug | By Email