Re: [quicwg/base-drafts] Describe the fields of packets (not packet headers) (#1567)
Kazuho Oku <notifications@github.com> Sun, 15 July 2018 06:50 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8C75B130DCD for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 23:50:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wOL1HNKnOCvp for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 23:50:48 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 70B811294D7 for <quic-issues@ietf.org>; Sat, 14 Jul 2018 23:50:48 -0700 (PDT)
Date: Sat, 14 Jul 2018 23:50:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531637446; bh=4590bcqREcFvD+OnGOQX05AGVX1Lnx2K60ZEifwTLBU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eq/0R3RzPJPMc07vv6VFnScoc7BqRK54h3bORDTSYq2QSrJHSctvSk5vSLhpHSSvP NdT3q7yN6mivfRQyiM4YT5WGIHQgb8dF0W8t9dZPYfFV9cqamDa+rcI4AJbpY5sb/E g16b6kTx7+nW6ZB37oQhfQ21yLI77S6vCofeR3Hg=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf1e0b1384e8c394aa42a56d58d5f2966b71bb05192cf000000011762b0c692a169ce14578ce7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1567/c405071401@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1567@github.com>
References: <quicwg/base-drafts/pull/1567@github.com>
Subject: Re: [quicwg/base-drafts] Describe the fields of packets (not packet headers) (#1567)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4aeec6a3de0_64c3f835fe3ef78135324"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/24ul5jmV2epI_nmIrX-d1iSVewI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jul 2018 06:50:51 -0000
Thank you for working on the changes. They look good to me. FWIW, I realized that this is an issue we should fix by looking at the fact that we could have two interpretations of where the token-len and token fields could be located in -13. One interpretation is that it is before the payload assuming that payload is not part of the header, and the other is that it should be after the payload because payload is defined as part of the header. It is source of confusion as you can see in #1535. While it is true that we will be moving the location of the token fields in #1498, I think this PR is worth the effort to avoid similar confusion in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1567#issuecomment-405071401
- [quicwg/base-drafts] Describe the fields of packe… Martin Thomson
- Re: [quicwg/base-drafts] Describe the fields of p… ianswett
- Re: [quicwg/base-drafts] Describe the fields of p… Kazuho Oku
- Re: [quicwg/base-drafts] Describe the fields of p… Marten Seemann
- Re: [quicwg/base-drafts] Describe the fields of p… Martin Thomson