IETF Logo Mail Archive

Re: [quicwg/base-drafts] DPLPMTUD fixes (#3606)

ianswett <notifications@github.com> Thu, 30 April 2020 15:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D88B13A0B2E for <quic-issues@ietfa.amsl.com>; Thu, 30 Apr 2020 08:46:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.302
X-Spam-Level:
X-Spam-Status: No, score=-2.302 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.82, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7T_elIZQwYEO for <quic-issues@ietfa.amsl.com>; Thu, 30 Apr 2020 08:46:00 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 219EC3A0B1E for <quic-issues@ietf.org>; Thu, 30 Apr 2020 08:44:19 -0700 (PDT)
Received: from github-lowworker-c53a806.ac4-iad.github.net (github-lowworker-c53a806.ac4-iad.github.net [10.52.23.45]) by smtp.github.com (Postfix) with ESMTP id 6655CE0534 for <quic-issues@ietf.org>; Thu, 30 Apr 2020 08:44:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1588261458; bh=p/W7xCCKfiw5dhXik6oSIhhjS6ChrGS5gam31nGMGlM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zBMsrwKTD8q8/3PyYoihDxZXqMkrZTSCI3JfNf/DYskza73of4mnYx3agTFWeEMSU 7gwi9huaalL7oi7nFLsw613Hi4QHbjlNscXTi5HRVPWwv1aPyZ9kLXoY5CtJIvgeSE 8Hj82haAZLAFHP9Bal//OiA3MSoG5eC0+2uYgjAs=
Date: Thu, 30 Apr 2020 08:44:18 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4IB3FU6RSLD2SI5VV4W3JVFEVBNHHCISO6GE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3606/review/403645283@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3606@github.com>
References: <quicwg/base-drafts/pull/3606@github.com>
Subject: Re: [quicwg/base-drafts] DPLPMTUD fixes (#3606)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eaaf25257010_407c3fc36f8cd968167859"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3-OsW03JDQMUjlCBvAUu9nSO72A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2020 15:46:02 -0000

@ianswett approved this pull request.

Thanks, LG

>  The endpoint SHOULD ignore all ICMP messages that fail validation.
 
-An endpoint MUST NOT increase PMTU based on ICMP messages.  Any reduction in the
-QUIC maximum packet size MAY be provisional until QUIC's loss detection
-algorithm determines that the quoted packet has actually been lost.
+An endpoint MUST NOT increase PMTU based on ICMP messages; see Section 3, clause
+6 of {{!DPLPMTUD}}.  Any reduction in the QUIC maximum packet size MAY be

```suggestion
6 of {{!DPLPMTUD}}.  Any reduction in the QUIC maximum packet size in response to ICMP messages MAY be
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3606#pullrequestreview-403645283

v2.23.0 | Report a Bug | By Email