Re: [quicwg/base-drafts] Wrongly hinting of issues not existing for packet number size increase (#605)

ianswett <notifications@github.com> Tue, 20 June 2017 16:52 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 713B212944C for <quic-issues@ietfa.amsl.com>; Tue, 20 Jun 2017 09:52:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.801
X-Spam-Level:
X-Spam-Status: No, score=-4.801 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JhgO0sqQ3W9t for <quic-issues@ietfa.amsl.com>; Tue, 20 Jun 2017 09:52:17 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E2AE9131531 for <quic-issues@ietf.org>; Tue, 20 Jun 2017 09:52:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ib4T4fqGPg0Vk6SqTNad1bFlQkQ=; b=lG2xjJqSzyXZbBWu KW6LWUFspIzjYhcuOqwXmquRtA2zd6DjBgHeFiVInsRYNagrVsUteNuy4uqk43FH Sezm/oUttRR+PDH39UMDvP+rgayY8vWttMRJWHVznERJh5zFStDgV/ZG+kohHEnw di5QD31U5YsQBZcvtxpm+aPgcxg=
Received: by filter1128p1mdw1.sendgrid.net with SMTP id filter1128p1mdw1-20036-594952B7-45 2017-06-20 16:52:07.621168058 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id 6Oy5cheASAyQ0TQjF1nZWQ for <quic-issues@ietf.org>; Tue, 20 Jun 2017 16:52:07.592 +0000 (UTC)
Date: Tue, 20 Jun 2017 09:52:07 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2267b7a3df0b08c52b4cded23949b926f439eeb692cf00000001156114b792a169ce0df59194@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/605/309820441@github.com>
In-Reply-To: <quicwg/base-drafts/issues/605@github.com>
References: <quicwg/base-drafts/issues/605@github.com>
Subject: Re: [quicwg/base-drafts] Wrongly hinting of issues not existing for packet number size increase (#605)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_594952b77c982_213233f8fa594bc3015449"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3Ikb8be//lB7dfOVgnWVcdqT/voOvOrp8BQO Oj/79YBFyxTgroYIQK3jsIXpsq9yceWuBGWgGh3Z8EFxpsSpUgj0SSAnCHTeDxkoCxHJaspC3QkYpH xylxTZ0DuNLfzlUW4778b0M4BacH+o92d3kUNQf2BTIpixjimXEa6mQJo54CG6WqR9W0IU/nNrLWXd k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/44TjziIMg51N9lw72l9a8wYf29E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2017 16:52:20 -0000

@martinthomson The concern you point out is real, though as @mcmanus points out, it just causes a few packets to be dropped when they can't be decrypted in the worst case.

Reordering is somewhat common, but reordering of >100 packets is pretty rare, so even 1 byte works very well in the real world.  

I remember there being some text on how to choose the packet number length, but I can't find it anymore.  The early draft(https://tools.ietf.org/html/draft-hamilton-quic-transport-protocol-00) had this text, which I think may have been lost when the packet header was changed?

"To enable unambiguous
      reconstruction of the packet number by the receiver, a QUIC
      endpoint MUST NOT transmit a packet whose packet number is larger
      by (2^(bitlength-2)) than the largest packet number for which an
      acknowledgement is known to have been transmitted by the receiver.
      Therefore, there must never be more than (2^46) packets in flight.
      Any truncated packet number received from a peer shall be inferred
      to have the value closest to the one more than the largest known
      packet number received from that peer.  The transmitted portion of
      the packet number matches the lowest bits of the inferred value."

To be clear, I think this text can be improved, but it's important to have a recommendation both based on number of packets currently outstanding and number that may be sent in the near future(likely limited by CWND).  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/605#issuecomment-309820441