Re: [quicwg/base-drafts] Allow Smaller Stateless Resets (#2927)

Nick Banks <notifications@github.com> Tue, 23 July 2019 13:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DED87120043 for <quic-issues@ietfa.amsl.com>; Tue, 23 Jul 2019 06:36:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8qCS7v6cLGfD for <quic-issues@ietfa.amsl.com>; Tue, 23 Jul 2019 06:36:21 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E2B38120033 for <quic-issues@ietf.org>; Tue, 23 Jul 2019 06:36:20 -0700 (PDT)
Date: Tue, 23 Jul 2019 06:36:19 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1563888979; bh=V7DwapvONE+6qf5muZT4fq1JERy9I/826BvizeGf29w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ewnFRRZ2SkJzfZM6vXXaYT/8uC4R7j6Xw3wANRfIdPRsqAgBdPXGu2KB/KTqc9kZ6 D0yDWkgfivoG8HC/Rk1HRxMytwtwGDF9rljWT2tuzXW5AE4OnRXfvKkjQsKiB4yIxt /ttKgUP5kXJUagdedaJfCmN3grbK7JieUX1WQjrw=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4E7WNF5EBRUSH4TSV3IQ75HEVBNHHBYHMRI4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2927/review/265411582@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2927@github.com>
References: <quicwg/base-drafts/pull/2927@github.com>
Subject: Re: [quicwg/base-drafts] Allow Smaller Stateless Resets (#2927)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d370d53cb8ff_628e3fee79ecd96435015"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7TSiMbAm28ntzSNgyzHBkvdZ_qE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jul 2019 13:36:23 -0000

nibanks commented on this pull request.



>  packet protection AEAD.  More unpredictable bytes might be necessary if the
 endpoint could have negotiated a packet protection scheme with a larger minimum
 AEAD expansion.
 
 An endpoint SHOULD NOT send a stateless reset that is significantly larger than
 the packet it receives.  Endpoints MUST discard packets that are too small to be
 valid QUIC packets.  With the set of AEAD functions defined in {{QUIC-TLS}},
-packets that are smaller than 21 bytes are never valid.
+packets that are smaller than 21 bytes are never valid.  When a packet is b

```suggestion
packets that are smaller than 21 bytes are never valid.
```
This looks like it was unintentional?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2927#pullrequestreview-265411582