Re: [quicwg/base-drafts] Refactor Push ID related errors (#2820)
Mike Bishop <notifications@github.com> Mon, 24 June 2019 17:09 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 44F10120688 for <quic-issues@ietfa.amsl.com>; Mon, 24 Jun 2019 10:09:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BxYi8cSS3kXH for <quic-issues@ietfa.amsl.com>; Mon, 24 Jun 2019 10:09:43 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5C814120132 for <quic-issues@ietf.org>; Mon, 24 Jun 2019 10:09:43 -0700 (PDT)
Date: Mon, 24 Jun 2019 10:09:42 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561396182; bh=4g9uuE2ig2fbyGOuv9b7AIXfIn+8Z6lw6dUftFa77HQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VmI0TNR8P11mS8JMAvqDURZ8zJ/fxh7Y51iZvSTNdB1MD2WmLkL1HH8jvaGC8KNaw UWV3etv29sU72iy7K2bVXV7y/Ic4jb7+Ft9ESJhnyUtFPE8rCp3t2dW6zUFk8G53Wx 78nzsn3BjiqqKA/HVXFbU77vACQP0c+fthM230cU=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY2JZZYBWEOUAN7KP53DY3FNEVBNHHBWV4V5Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2820/review/253543250@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2820@github.com>
References: <quicwg/base-drafts/pull/2820@github.com>
Subject: Re: [quicwg/base-drafts] Refactor Push ID related errors (#2820)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d1103d6474a3_25e23fb19bccd9681494ee"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/89AXdhOD3egkw8Qzlvqq7X2t_4c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Jun 2019 17:09:45 -0000
MikeBishop approved this pull request. > @@ -1630,12 +1633,12 @@ HTTP_VERSION_FALLBACK (0x09): HTTP_WRONG_STREAM (0x0A): : A frame was received on a stream where it is not permitted. -HTTP_LIMIT_EXCEEDED (0x0B): -: A Stream ID, Push ID, or Placeholder ID greater than the current maximum for - that identifier was referenced. +HTTP_ID_ERROR (0x0B): +: A Stream ID, Push ID, or Placeholder ID was used incorrectly, such as + exceeding a limit, reducing a limit or being reused. ```suggestion exceeding a limit, reducing a limit, or being reused. ``` > @@ -1912,8 +1915,8 @@ The entries in the following table are registered by this document. | HTTP_EXCESSIVE_LOAD | 0x0008 | Peer generating excessive load | {{http-error-codes}} | | HTTP_VERSION_FALLBACK | 0x0009 | Retry over HTTP/1.1 | {{http-error-codes}} | | HTTP_WRONG_STREAM | 0x000A | A frame was sent on the wrong stream | {{http-error-codes}} | -| HTTP_LIMIT_EXCEEDED | 0x000B | An identifier limit was exceeded | {{http-error-codes}} | -| HTTP_DUPLICATE_PUSH | 0x000C | Push ID was fulfilled multiple times | {{http-error-codes}} | +| HTTP_ID_ERROR | 0x000B | An identifier used incorrectly | {{http-error-codes}} | ```suggestion | HTTP_ID_ERROR | 0x000B | An identifier was used incorrectly | {{http-error-codes}} | ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2820#pullrequestreview-253543250
- [quicwg/base-drafts] Refactor Push ID related err… Lucas Pardue
- Re: [quicwg/base-drafts] Refactor Push ID related… Lucas Pardue
- Re: [quicwg/base-drafts] Refactor Push ID related… Lucas Pardue
- Re: [quicwg/base-drafts] Refactor Push ID related… Kazuho Oku
- Re: [quicwg/base-drafts] Refactor Push ID related… Mike Bishop
- Re: [quicwg/base-drafts] Refactor Push ID related… Lucas Pardue
- Re: [quicwg/base-drafts] Refactor Push ID related… Mike Bishop