[quicwg/base-drafts] bc19b6: WIP: Reorganize QPACK
afrind <afrind@users.noreply.github.com> Wed, 21 November 2018 16:44 UTC
Return-Path: <bounce+565321.40f-quic-issues=ietf.org@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BD2D51274D0 for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 08:44:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.661
X-Spam-Level:
X-Spam-Status: No, score=-0.661 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-1.46, DKIM_ADSP_NXDOMAIN=0.8, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZZ2kfhwoRw9w for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 08:44:44 -0800 (PST)
Received: from m69-169.mailgun.net (m69-169.mailgun.net [166.78.69.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C68F5130DF2 for <quic-issues@ietf.org>; Wed, 21 Nov 2018 08:44:44 -0800 (PST)
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=github.com; q=dns/txt; s=mailo; t=1542818683; h=Content-Transfer-Encoding: Content-Type: Mime-Version: Subject: Message-ID: To: Reply-To: From: Date: Sender; bh=+k4E3oznSTuEd2ouA1A39sI0dnErlVL3L1YrZ3/nKng=; b=dOUtEN3+DSiP2JsgnrfXrF4JzjSHCpdl2uPqJzwG/HgqqHC2l8kyHyHoQBRtJREWgm8kIy4t BZIoFR/R64F04CMJ2f2e8n7QxIFippHmRA/xWGqeUlGzQGUAw7YHU9Jhi51+M3cz6nm5Bp0b l1ODTyU+KXW2QwQT40UzpnmDuvc=
X-Mailgun-Sending-Ip: 166.78.69.169
X-Mailgun-Sid: WyJhNzYyYiIsICJxdWljLWlzc3Vlc0BpZXRmLm9yZyIsICI0MGYiXQ==
Sender: afrind=users.noreply.github.com@github.com
Received: from github.com (Unknown [192.30.252.34]) by mxa.mailgun.org with ESMTP id 5bf58b7b.7f33fc6d3570-smtp-out-n02; Wed, 21 Nov 2018 16:44:43 -0000 (UTC)
Date: Wed, 21 Nov 2018 08:44:42 -0800
From: afrind <afrind@users.noreply.github.com>
Reply-To: afrind <afrind@users.noreply.github.com>
To: quic-issues@ietf.org
Message-ID: <5bf58b7a46f85_1a9f2af5a9852590349bd@hookshot-fe-7191cb1.cp1-iad.github.net.mail>
Subject: [quicwg/base-drafts] bc19b6: WIP: Reorganize QPACK
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="--==_mimepart_5bf58b7a46bad_1a9f2af5a985259034875"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8mhe5r2jTSc3_Ju6HI0Yt3mjl_0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Nov 2018 16:44:47 -0000
Branch: refs/heads/master Home: https://github.com/quicwg/base-drafts Commit: bc19b645446fc039c25e23a8c515d233f928f372 https://github.com/quicwg/base-drafts/commit/bc19b645446fc039c25e23a8c515d233f928f372 Author: Alan Frindell <afrind@fb.com> Date: 2018-10-29 (Mon, 29 Oct 2018) Changed paths: M draft-ietf-quic-qpack.md Log Message: ----------- WIP: Reorganize QPACK Added a "Compression Process Overview" section near the top, with a high level description of how to compress/decompress. This section now encompasses a lot of what used to be "Encoding Strategies". In the places where I added new text, I temporarily added HTML comments to indicicate so it can get a bit more detailed review. I also deleted a few sentences/paragraphs/sections that I found to be redundant: - Preventing Eviction Races - "An encoder also respects..." - "For header blocks encoded in..." - Single Pass Encoding - "All table updates occur on..." Commit: 6ff9fda2a2e74b5a29fe26a81b57579e07f54283 https://github.com/quicwg/base-drafts/commit/6ff9fda2a2e74b5a29fe26a81b57579e07f54283 Author: Alan Frindell <afrind@fb.com> Date: 2018-10-29 (Mon, 29 Oct 2018) Changed paths: M draft-ietf-quic-qpack.md Log Message: ----------- Address most editorial comments Not addressed: 1. I left the drawing with 'Draining Entries' without a specific definition in the text. I think it can be interpreted OK, and 'Unreferencable' isn't actually true. 2. With respect to leaving blocked data in flow control, I changed should to SHOULD instead of can. My understanding is that you don't have to do a SHOULD, if you have a good reason? It's important enough that we want to convey more than ability. 3. I skipped redoing the indexing diagram for its own commit 4. I haven't moved the TSS guidance out of the TSS instruction section yet. I can't lift the whole paragraph without refactoring some of the other text. 5. I think peer's encoder/decoder is correctly possessive. Doesn't the coder belong to the peer? 6. I removed all the instances of 'A decoder', but there are still a bunch of references to 'An encoder'. I'm not sure if the consistency is an improvement in readability yet, so delaying changing more pending feedback. Commit: 5e54faf7111c78cbfe62fa934c3fcbe7e83f7102 https://github.com/quicwg/base-drafts/commit/5e54faf7111c78cbfe62fa934c3fcbe7e83f7102 Author: Alan Frindell <afrind@fb.com> Date: 2018-10-30 (Tue, 30 Oct 2018) Changed paths: M draft-ietf-quic-qpack.md Log Message: ----------- Addressing more editorial feedback I missed some of the comments in the first pass. Commit: 914c9557cf141aa37906711ee166afec35d24393 https://github.com/quicwg/base-drafts/commit/914c9557cf141aa37906711ee166afec35d24393 Author: Alan Frindell <afrind@fb.com> Date: 2018-11-19 (Mon, 19 Nov 2018) Changed paths: M draft-ietf-quic-qpack.md Log Message: ----------- More editorial changes Mostly wordsmithing Moved one section from TSS wire to decoder Commit: b93d8218813fc2d9d097068d7baa0efe3cc26036 https://github.com/quicwg/base-drafts/commit/b93d8218813fc2d9d097068d7baa0efe3cc26036 Author: afrind <afrind@users.noreply.github.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M draft-ietf-quic-qpack.md Log Message: ----------- Merge pull request #1852 from quicwg/reorg-qpack WIP: Reorganize QPACK Compare: https://github.com/quicwg/base-drafts/compare/9b2c9296a279...b93d8218813f **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.