Re: [quicwg/base-drafts] only require RESET_STREAM on STOP_SENDING in Ready and Sent state (#2268)
Martin Thomson <notifications@github.com> Mon, 31 December 2018 02:26 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3285F127598 for <quic-issues@ietfa.amsl.com>; Sun, 30 Dec 2018 18:26:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.447
X-Spam-Level:
X-Spam-Status: No, score=-6.447 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UmG-TjWDGl2T for <quic-issues@ietfa.amsl.com>; Sun, 30 Dec 2018 18:26:42 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A9D812008A for <quic-issues@ietf.org>; Sun, 30 Dec 2018 18:26:42 -0800 (PST)
Date: Sun, 30 Dec 2018 18:26:41 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546223201; bh=2rWnuszdMksrakqRJV35CVIwinwGgcWvouEp38/tdl4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kOTh5l2Twt5EB8bkKk9Mu6mLc62V8cKPTOejd3l/qUCSP7IjW3xbwOeocDCYFvtXC lhYtD9Z82DzuRD0R0x+gYJwZX6EoN3GdNCU9ih2sUF1M1/yN+KGO27LvOXc58PvHUW Fq8bpyyn4MHi4nztgQubYJ2tnRwB93/4hpceJtsY=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab595bbde3468275d775792c43cb36206aaa6a7a2992cf000000011841406192a169ce17856d43@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2268/review/188457150@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2268@github.com>
References: <quicwg/base-drafts/pull/2268@github.com>
Subject: Re: [quicwg/base-drafts] only require RESET_STREAM on STOP_SENDING in Ready and Sent state (#2268)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c297e61ad8bf_4b953f886b8d45b8484342"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9-4NGu7XEwO1k2y8_II5rimOY4k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Dec 2018 02:26:44 -0000
martinthomson requested changes on this pull request. I think that this needs to include Data Sent also. Though the end of stream might be in flight, you have no assurance that it was received (yet). You could say that the endpoint MAY defer sending the RESET_STREAM until any outstanding data on the stream is declared lost. The text you quote can be struck. The race here we were trying to service isn't really one we need to deal with - we mandate the use of STOP_SENDING in response to RESET_STREAM. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2268#pullrequestreview-188457150
- [quicwg/base-drafts] only require RESET_STREAM on… Marten Seemann
- Re: [quicwg/base-drafts] only require RESET_STREA… Martin Thomson
- Re: [quicwg/base-drafts] only require RESET_STREA… Marten Seemann
- Re: [quicwg/base-drafts] only require RESET_STREA… Martin Thomson
- Re: [quicwg/base-drafts] only require RESET_STREA… Kazuho Oku
- Re: [quicwg/base-drafts] only require RESET_STREA… Mike Bishop
- Re: [quicwg/base-drafts] only require RESET_STREA… Martin Thomson