Re: [quicwg/base-drafts] Don't use ECN if packets are discarded (#2750)
MikkelFJ <notifications@github.com> Wed, 22 May 2019 14:54 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7A10512014B for <quic-issues@ietfa.amsl.com>; Wed, 22 May 2019 07:54:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.606
X-Spam-Level:
X-Spam-Status: No, score=-1.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cQ__FwlD0N2W for <quic-issues@ietfa.amsl.com>; Wed, 22 May 2019 07:54:43 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2BF3E12013F for <quic-issues@ietf.org>; Wed, 22 May 2019 07:54:27 -0700 (PDT)
Date: Wed, 22 May 2019 07:54:26 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1558536866; bh=P3uqvGwKqvO5eY+OdS15km4tl3AUaQSU3z2UMMKxktc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=k+R/uHWlxcjWXpTKhSfh2f5F28QoQY9UO+VU260ziSxfFzRvlrT8m8anoJxdjpoj3 H9bAECrlawlSDKoK7BcDYtI8wAVUpRsdpIznfi2hXvkubKQ+fQM9Qual45vHgbU/+2 ATgDxjxkfeWSCNcOYV1YXVBmgKZwJOUxMhh7Sfqc=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2YZYL5EKAWZ5ODJMV26KKSFEVBNHHBVJ2ZR4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2750/review/240687967@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2750@github.com>
References: <quicwg/base-drafts/pull/2750@github.com>
Subject: Re: [quicwg/base-drafts] Don't use ECN if packets are discarded (#2750)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ce562a213eec_49a73fa7a8acd96c22344d8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/B9MYmid2xqMPSeR3i6pPa_Oze1M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 May 2019 14:54:47 -0000
mikkelfj commented on this pull request.
> @@ -5403,8 +5403,9 @@ their effects in more detail.
An on-the-side attacker can duplicate and send packets with modified ECN
codepoints to affect the sender's rate. If duplicate packets are discarded by a
receiver, an off-path attacker will need to race the duplicate packet against
-the original to be successful in this attack. Therefore, QUIC receivers ignore
-ECN codepoints set in duplicate packets (see {{ecn}}).
+the original to be successful in this attack. Therefore, QUIC endpoints ignore
+the ECN codepoint field on an IP packet unless a QUIC packet in that IP packet
```suggestion
the ECN codepoint field on an IP packet unless at least one QUIC packet in that IP packet
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2750#pullrequestreview-240687967
- [quicwg/base-drafts] Don't use ECN if packets are… Martin Thomson
- Re: [quicwg/base-drafts] Don't use ECN if packets… mirjak
- Re: [quicwg/base-drafts] Don't use ECN if packets… MikkelFJ
- Re: [quicwg/base-drafts] Don't use ECN if packets… Martin Thomson
- Re: [quicwg/base-drafts] Don't use ECN if packets… ianswett
- Re: [quicwg/base-drafts] Don't use ECN if packets… Martin Thomson