Re: [quicwg/base-drafts] Apply suggestions from code review (eb58201)

Mike Bishop <notifications@github.com> Tue, 20 November 2018 19:36 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5CFDB12785F for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 11:36:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.066
X-Spam-Level:
X-Spam-Status: No, score=-2.066 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pVlmyyN44WjB for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 11:36:23 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7EBD012D4E9 for <quic-issues@ietf.org>; Tue, 20 Nov 2018 11:36:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=T6k7DdSiEpRL6Cb0EFErZxwhukI=; b=FdBZvx95/FBxIdes QGAkdoRRX3iFZ7MubZ3lAsS9ypymQzjxMsfeCKPBy4v5Topdb2npIll8tZXG9ZhU +dljSff21T0WjjYau5x3T6I93sUZvTEMO6X8sso3jk5KLxcDzITCo8vlOi3GE6Cc 3YwoHRq9NlENUhpV0lVIjtXUMN8=
Received: by filter0874p1las1.sendgrid.net with SMTP id filter0874p1las1-20824-5BF46234-15 2018-11-20 19:36:20.560807343 +0000 UTC m=+422048.800304919
Received: from github-lowworker-63e61ec.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id dQpOlJkWQNKx8DVDoF--gg for <quic-issues@ietf.org>; Tue, 20 Nov 2018 19:36:20.365 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-63e61ec.cp1-iad.github.net (Postfix) with ESMTP id 581A32A06B9 for <quic-issues@ietf.org>; Tue, 20 Nov 2018 11:36:20 -0800 (PST)
Date: Tue, 20 Nov 2018 19:36:20 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab55b4de4e747bf261f3759ecdabb940dc62ff6a6c92cf00000001180c243492a163ce01deb11e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/commit/eb58201482ac4ed045591927e81ae6dcf131aecc/31371550@github.com>
In-Reply-To: <quicwg/base-drafts/commit/eb58201482ac4ed045591927e81ae6dcf131aecc@github.com>
References: <quicwg/base-drafts/commit/eb58201482ac4ed045591927e81ae6dcf131aecc@github.com>
Subject: Re: [quicwg/base-drafts] Apply suggestions from code review (eb58201)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf462345699e_257f3f932fcd45b8126765"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2zsMdDGU38tDSbxkSdphznPXZo1gj5T8uOsn /38MAAuN91ncMHcJiKOg4SLQWSLbH0LalDZxHkEihh88NqrGLzotgYML3ETr3ZnuomS404/vpLR7TP q85JpDTxV5Xq6nyLl9uMLByACsOq5nrBgVRTD9S22pmpNq7CWZfcBwUSlIX3AVo6FpHqK+69hP4TzR 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BkRnLCPwvH9V0muL6p4Y1f65EHw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 19:36:25 -0000

I'm not clear why.  If you received a complete message, you'll send a complete message back (potentially containing an error at the HTTP semantic layer).  If you didn't receive a complete message, there's an error already defined for that.  If the stream hasn't closed yet, you just wait (subject to guard timers, slowloris attacks, etc.).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/commit/eb58201482ac4ed045591927e81ae6dcf131aecc#commitcomment-31371550