Re: [quicwg/base-drafts] Add FACK reference (#2119)

ianswett <notifications@github.com> Wed, 12 December 2018 01:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2B5E5130FC7 for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 17:23:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Level:
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zCIgRePFOAEZ for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 17:23:45 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A668130FBA for <quic-issues@ietf.org>; Tue, 11 Dec 2018 17:23:45 -0800 (PST)
Date: Tue, 11 Dec 2018 17:23:44 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544577824; bh=PAXrXF099oMLA/51BNituX5hhWIMOdx6lmjBvwR+tUE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bEs8KzjYrQULFPrk0cKgluAw48NTKTYWaxGHBfRDO3nBDzfo3NNEIPlmnuHbbmpfs 4VhIZ4R68S2V8vXpKm2yILzN7gWhUKPW6ofsJqa46bHDNsQInSt6MX9+QxKzlXbBP2 D3kM3lCl3QkM7gBPVViCk0t435ZC6uy72XiHh6vk=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab69729378124336fdcb6d58e34ca03013fc4c938692cf000000011828252092a169ce173f3512@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2119/review/183979324@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2119@github.com>
References: <quicwg/base-drafts/pull/2119@github.com>
Subject: Re: [quicwg/base-drafts] Add FACK reference (#2119)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c10632070750_7a863ffc340d45c456847"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EK6dz8qskPyycbiyrv1OnyO79fo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Dec 2018 01:23:47 -0000

ianswett commented on this pull request.



> @@ -325,7 +334,8 @@ smaller initial reordering thresholds to minimize recovery latency.
 ### Packet Threshold
 
 The RECOMMENDED initial value for the packet reordering threshold
-(kPacketThreshold) is 3, based on TCP loss detection {{?RFC5681}} {{?RFC6675}}.
+(kPacketThreshold) is 3, based on best practices for TCP loss detection
+{{?RFC5681}} {{?RFC6675}} {{FACK}}.

We mention FACK in "## Ack-based Detection", so I thought it might make more sense there?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2119#pullrequestreview-183979324