Re: [quicwg/base-drafts] Reset connection state on retry and VN (#2040)
Marten Seemann <notifications@github.com> Thu, 22 November 2018 01:39 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 30CEE130EAB for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 17:39:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MP0_cVO0Gldl for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 17:39:28 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49DFB130EA9 for <quic-issues@ietf.org>; Wed, 21 Nov 2018 17:39:28 -0800 (PST)
Date: Wed, 21 Nov 2018 17:39:27 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542850767; bh=DQ2l2kBGVwgytiIHFzuCSMUu+7sHYm+TJoLu+o6ghxs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=M368ynxyMCf7A2/B1zzv9FVdSE9cTIgtolh5OV4yJJzS8Xp6bHjEUJVWtNNL0wuAF Sgj4DO0DdPj5vd0X8B0640GxjC77THH4z4Pq7Ezno11A7xZqobwi6/cPnEUl+PoN8q 1Hd8X0/wF4hlQK884kWo2nS/y2JCq59i105ouKfc=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab329394559b4251bbf0cfdea7ff04a27bed00aabb92cf00000001180dcacf92a169ce16d91712@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2040/review/177479350@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2040@github.com>
References: <quicwg/base-drafts/pull/2040@github.com>
Subject: Re: [quicwg/base-drafts] Reset connection state on retry and VN (#2040)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf608cf4d813_2a9b3fbb94ed45c457992"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EboQmToOMoxT2hlHPKRcYLNKdKk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Nov 2018 01:39:30 -0000
marten-seemann commented on this pull request. I’m not sure if a change to the recovery draft is sufficient to cover the whole scope of what’s happening when receiving one of these two packets. We’re also resetting flow control offsets (the CRYPTO stream starts at offset 0 again), as well as stream state related when sending 0-RTT data. I like the text here, maybe we can move it to the transport doc, and add that this covers all state created, except for connection IDs, packet numbers and, optionally, an RTT measurement. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2040#pullrequestreview-177479350
- [quicwg/base-drafts] Reset connection state on re… janaiyengar
- Re: [quicwg/base-drafts] Reset connection state o… MikkelFJ
- Re: [quicwg/base-drafts] Reset connection state o… Martin Thomson
- Re: [quicwg/base-drafts] Reset connection state o… janaiyengar
- Re: [quicwg/base-drafts] Reset connection state o… janaiyengar
- Re: [quicwg/base-drafts] Reset connection state o… Marten Seemann
- Re: [quicwg/base-drafts] Reset connection state o… Martin Thomson
- Re: [quicwg/base-drafts] Reset connection state o… ianswett
- Re: [quicwg/base-drafts] Reset connection state o… janaiyengar