[quicwg/base-drafts] e0e024: Out of order relative to other ack-eliciting packets

Jana Iyengar <noreply@github.com> Tue, 01 September 2020 19:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BF8763A0FC7 for <quic-issues@ietfa.amsl.com>; Tue, 1 Sep 2020 12:48:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.101
X-Spam-Level:
X-Spam-Status: No, score=-2.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QOGxVa2lMqAw for <quic-issues@ietfa.amsl.com>; Tue, 1 Sep 2020 12:48:47 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 66E4D3A0FBD for <quic-issues@ietf.org>; Tue, 1 Sep 2020 12:48:47 -0700 (PDT)
Received: from github.com (hubbernetes-node-480c91b.va3-iad.github.net [10.48.112.40]) by smtp.github.com (Postfix) with ESMTPA id B7CB3340E95 for <quic-issues@ietf.org>; Tue, 1 Sep 2020 12:48:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598989726; bh=GVa12ryZJSarRbZ3WlPIJAR6OyK50kFkXfrSAlVXQYU=; h=Date:From:To:Subject:From; b=KK7n+1mTJlH1YGttEb30Gf5+gjchMBNAXHOTO0kGZ4jqiKkk7PH1gy0AAZx8HechM gphjQlfwoxqMUfcV+LxvjcUQkTrjzQ6GczQ539N+TCj7vXRrdSAJAdvTAu7joT7ooP aSF7xM57Iuxv2JE5yQt+vtDXLEM4y5soPm8cyXmY=
Date: Tue, 01 Sep 2020 12:48:46 -0700
From: Jana Iyengar <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/master/ad3605-877ec7@github.com>
Subject: [quicwg/base-drafts] e0e024: Out of order relative to other ack-eliciting packets
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GgHD6Oe5HHAxAQ5o0izrB42bqrw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Sep 2020 19:48:49 -0000

  Branch: refs/heads/master
  Home:   https://github.com/quicwg/base-drafts
  Commit: e0e024dd0456160102bdf39314417ebd048361ab
      https://github.com/quicwg/base-drafts/commit/e0e024dd0456160102bdf39314417ebd048361ab
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-08-16 (Sun, 16 Aug 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Out of order relative to other ack-eliciting packets

I believe this was the existing intent, so not filing an issue, people can feel free to disagree.

The case I'm concerned about is an ACK arrives with PN 10, then PN 9 arrives.  I do not believe PN 9 should not be considered 'out-of-order' and trigger an immediate ACK.  Recovery is designed with this case in mind, but when re-reading this text, I thought it was unclear.


  Commit: 3ca0b89c8bd6caddc68559084fbfbd1095899436
      https://github.com/quicwg/base-drafts/commit/3ca0b89c8bd6caddc68559084fbfbd1095899436
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Update draft-ietf-quic-transport.md

Co-authored-by: Martin Thomson <mt@lowentropy.net>


  Commit: 5cdb166db5f2d9ccc5745129511d91a12b334937
      https://github.com/quicwg/base-drafts/commit/5cdb166db5f2d9ccc5745129511d91a12b334937
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Martin's suggestion

I tweaked it a bit, but not much.


  Commit: ea6359f86f09fce5b206fe27f6ff5753b9b1ccd8
      https://github.com/quicwg/base-drafts/commit/ea6359f86f09fce5b206fe27f6ff5753b9b1ccd8
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Update draft-ietf-quic-transport.md


  Commit: b89274cb3f88af6986917455310fa0438649d5b1
      https://github.com/quicwg/base-drafts/commit/b89274cb3f88af6986917455310fa0438649d5b1
  Author: Mike Bishop <mbishop@evequefou.be>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Line break to enable bullets


  Commit: a881299b06fe25abaee03fb192693583b4f6af93
      https://github.com/quicwg/base-drafts/commit/a881299b06fe25abaee03fb192693583b4f6af93
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-08-18 (Tue, 18 Aug 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Update draft-ietf-quic-transport.md

Co-authored-by: Martin Thomson <mt@lowentropy.net>


  Commit: d7a4c50c6b159ba69a75f6ef136c7de09e702b9c
      https://github.com/quicwg/base-drafts/commit/d7a4c50c6b159ba69a75f6ef136c7de09e702b9c
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-08-18 (Tue, 18 Aug 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Update draft-ietf-quic-transport.md


  Commit: c467dba1750a3bece8cae6ba082bc464fe0f5026
      https://github.com/quicwg/base-drafts/commit/c467dba1750a3bece8cae6ba082bc464fe0f5026
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-08-18 (Tue, 18 Aug 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Remove out-of-order definition


  Commit: b7b431b4c364e0751ab0360eb041717e78e1ecad
      https://github.com/quicwg/base-drafts/commit/b7b431b4c364e0751ab0360eb041717e78e1ecad
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-08-18 (Tue, 18 Aug 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Remove redundant SHOULD NOT


  Commit: 877ec755036791e4944c303b9ec862281823ba92
      https://github.com/quicwg/base-drafts/commit/877ec755036791e4944c303b9ec862281823ba92
  Author: Jana Iyengar <jri.ietf@gmail.com>
  Date:   2020-09-01 (Tue, 01 Sep 2020)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Merge pull request #4000 from quicwg/ianswett-out-of-order-ack

Out of order relative to other ack-eliciting packets


Compare: https://github.com/quicwg/base-drafts/compare/ad3605bf17cf...877ec7550367