Re: [quicwg/base-drafts] QPACK: add examples (#4093)

[Martin Thomson <[e-mail]>]

@martinthomson commented on this pull request.

It looks like there is a small error (just with attribution, not the encoding), but this covers most of the important cases.  It's a shame that the indices are so small, because I don't think that this provides enough information for someone to understand how references to the dynamic table work.  All references in examples have an encoded index of 0.

> +510b 2f69 6e64 6578 | Literal Field Line with Name Reference
+2e68 746d 6c        |  (:path=/index.html)

It might help if you include the numeric values included in each of these descriptions.  In this case, it's (static table 1).

> +                                ^-- acknowledged --^
+                                Size=0
+~~~
+
+## Dynamic Table
+
+The encoder sets the dynamic table capacity, inserts a header with a dynamic
+name reference, then sends a potentially blocking, encoded field section
+referencing this new entry.  The decoder acknowledges processing the encoded
+field section.
+
+~~~
+Stream: Encoder
+3f8b                | Set Dynamic Table Capacity=170
+01c0 0c77 7777 2e69 | Insert With Name Reference (static table)
+6574 662e 6f72 67   |  (:authortiy=www.ietf.org)

```suggestion
7466 2e6f 7267      |  (:authority=www.ietf.org)
```

> +
+                                Abs Ref Name        Value
+                                ^-- acknowledged --^
+                                Size=0
+~~~
+
+## Dynamic Table
+
+The encoder sets the dynamic table capacity, inserts a header with a dynamic
+name reference, then sends a potentially blocking, encoded field section
+referencing this new entry.  The decoder acknowledges processing the encoded
+field section.
+
+~~~
+Stream: Encoder
+3f8b                | Set Dynamic Table Capacity=170

I read this as extending to the next byte.

```suggestion
3f8b01              | Set Dynamic Table Capacity=170
```

> +                                Abs Ref Name        Value
+                                ^-- acknowledged --^
+                                Size=0
+~~~
+
+## Dynamic Table
+
+The encoder sets the dynamic table capacity, inserts a header with a dynamic
+name reference, then sends a potentially blocking, encoded field section
+referencing this new entry.  The decoder acknowledges processing the encoded
+field section.
+
+~~~
+Stream: Encoder
+3f8b                | Set Dynamic Table Capacity=170
+01c0 0c77 7777 2e69 | Insert With Name Reference (static table)

```suggestion
c00c 7777 772e 6965 | Insert With Name Reference (static table 0)
```

> +Stream: 0
+0000                | Required Insert Count = 0, Base = 0
+510b 2f69 6e64 6578 | Literal Field Line with Name Reference
+2e68 746d 6c        |  (:path=/index.html)
+
+                                Abs Ref Name        Value
+                                ^-- acknowledged --^
+                                Size=0
+~~~
+
+## Dynamic Table
+
+The encoder sets the dynamic table capacity, inserts a header with a dynamic
+name reference, then sends a potentially blocking, encoded field section
+referencing this new entry.  The decoder acknowledges processing the encoded
+field section.

```suggestion
field section, which transitively acknowledges the encoder instructions up to the Required Insert Count.
```

Or something like that.

> +
+~~~
+Stream: Encoder
+3f8b                | Set Dynamic Table Capacity=170
+01c0 0c77 7777 2e69 | Insert With Name Reference (static table)
+6574 662e 6f72 67   |  (:authortiy=www.ietf.org)
+
+                                Abs Ref Name        Value
+                                ^-- acknowledged --^
+                                 1   0  :authority  www.ietf.org
+                                Size=54
+
+Stream: 4
+0280                | Required Insert Count = 1, Base = 0
+10                  | Indexed Field Line With Post-Base Index
+                    |  Absolute Index=1

This one is useful to break down (RIC + delta_base + 0 = 1).  Shame that we have such small numbers involved here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4093#pullrequestreview-487423724