[quicwg/base-drafts] Clarification on Setting the Loss Detection Timer in the loss recovery draft (#2093)

Nasif Ekiz <notifications@github.com> Mon, 03 December 2018 21:01 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 145611294D0 for <quic-issues@ietfa.amsl.com>; Mon, 3 Dec 2018 13:01:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3k3rmnLtO93w for <quic-issues@ietfa.amsl.com>; Mon, 3 Dec 2018 13:01:19 -0800 (PST)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4F4EE1200B3 for <quic-issues@ietf.org>; Mon, 3 Dec 2018 13:01:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Z7dkiwLN5OYcwFFXnVid+LiAwRk=; b=k+NOxJUqP0eDNOoo 1ECI8UHVRS7HI/kYOdgA1bE1RQo7N7IN/cyK/juKhYYxTsHB2s8p7CtTpCJ8R2xS 0S2Pu4gn/8AUZjrv+bL5kImbKPNUvFL6ZDcP8+kYz98Y1LvYMSJc5YPonV+MizLY LabXnXo12IIOKJgBEkVzXP4Y+9E=
Received: by filter0805p1las1.sendgrid.net with SMTP id filter0805p1las1-23305-5C05999D-31 2018-12-03 21:01:18.063711575 +0000 UTC m=+142015.474886228
Received: from github-lowworker-5909e27.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0036p1iad1.sendgrid.net (SG) with ESMTP id lNCZIArSQ96gB98xoxWYFg for <quic-issues@ietf.org>; Mon, 03 Dec 2018 21:01:17.965 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-5909e27.cp1-iad.github.net (Postfix) with ESMTP id E9D4B3E0072 for <quic-issues@ietf.org>; Mon, 3 Dec 2018 13:01:17 -0800 (PST)
Date: Mon, 03 Dec 2018 21:01:18 +0000
From: Nasif Ekiz <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab47536e7008c911a089eb94fe7e8efec200eef36c92cf00000001181d5b9d92a169ce171134fd@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2093@github.com>
Subject: [quicwg/base-drafts] Clarification on Setting the Loss Detection Timer in the loss recovery draft (#2093)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c05999de7aa8_388a3fdc732d45bc18453b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nekiz
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1MB3rYlldHIfGeZ4JD+cGlIpZir355LoC0jf ZQlzRPMM3E0T+uSu4zQxhiC2Cyf1CynrmzP9YQY+JBkTHJuUPfDgbfHdNMWzdsNXh3jjPV8V7NY999 Ypq0Rmque8gF/TQt+3AQ6jyKuHVUwYGhQWJqobkGLlov56BS3Kq9BxtcOrgfhZRAYC3LywvUsorlGq s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/I87JQGoz5ywniKaP1DeXhepcDTI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2018 21:01:21 -0000

Setting the Loss Detection Timer section states:

    // Don't arm timer if there are no retransmittable packets
    // in flight.
    if (bytes_in_flight == 0):
      loss_detection_timer.cancel()
      return

If a QUIC sender sends multiple retransmittable packets and some ACK/PADDING packets and only retransmittable packets are ACKed, it leaves the bytes_in_flight > 0 but no retransmittable packets inflight. In this case, Loss Detection Timer need not be scheduled as there is not retransmittable packets inflight but the above check results in scheduling the timer again.

if (bytes_in_flight == 0): check does not seem enough by itself to decide if there are outstanding retransmittable packets. Do we need to update that section? 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2093