Re: [quicwg/base-drafts] In-flight not outstanding (#2120)
janaiyengar <notifications@github.com> Wed, 12 December 2018 23:06 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D8C0F130F32 for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 15:06:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M_qTPJVyjE7b for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 15:06:07 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 968E3130F29 for <quic-issues@ietf.org>; Wed, 12 Dec 2018 15:06:07 -0800 (PST)
Date: Wed, 12 Dec 2018 15:06:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544655966; bh=LwnPkFYeCCkZpDeKRCxAfBQKTP7DLL0SHnWfnw1XG6w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DRNxCmG593Mf35OFrRrnynQQhxxkVThgIKMiLaCOdXb6d56HCMlUTf7phKoFw0tL9 I+buA3YIT9ShzKGc7qQaYK4EJCe5imaOPyPDiyWwqVt88v7XvUCTtWVLZLlCQdVx8T g5QDENwyDoR/tKIdtmXHoZUn+2yKWX0pqvEHB0Z0=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7e8cd0eb8e03ef6ef124f456446c03536a606e1692cf000000011829565e92a169ce173f819a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2120/review/184436678@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2120@github.com>
References: <quicwg/base-drafts/pull/2120@github.com>
Subject: Re: [quicwg/base-drafts] In-flight not outstanding (#2120)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c11945e7f04c_3d6b3f81de6d45bc123765"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/IXlgIMpGbfju4GAIVWXBrePAC0M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Dec 2018 23:06:10 -0000
janaiyengar commented on this pull request. Using "data in flight" is fine without the hyphenation. > @@ -400,7 +400,7 @@ On each consecutive expiration of the crypto timer without receiving an acknowledgement for a new packet, the sender SHOULD double the crypto retransmission timeout and set a timer for this period. -When crypto packets are outstanding, the TLP and RTO timers are not active. +When crypto packets are in-flight, the TLP and RTO timers are not active. ```suggestion When crypto packets are in flight, the TLP and RTO timers are not active. ``` > @@ -436,9 +436,9 @@ conditions: PTO SHOULD be scheduled for min(RTO, PTO). QUIC includes MaxAckDelay in all probe timeouts, because it assumes the ack -delay may come into play, regardless of the number of packets outstanding. -TCP's TLP assumes if at least 2 packets are outstanding, acks will not be -delayed. +delay may come into play, regardless of the number of packets ack-eliciting +packets in-flight. TCP's TLP assumes if at least 2 ack-eliciting packets are ```suggestion packets in flight. TCP's TLP assumes if at least 2 ack-eliciting packets are ``` > @@ -436,9 +436,9 @@ conditions: PTO SHOULD be scheduled for min(RTO, PTO). QUIC includes MaxAckDelay in all probe timeouts, because it assumes the ack -delay may come into play, regardless of the number of packets outstanding. -TCP's TLP assumes if at least 2 packets are outstanding, acks will not be -delayed. +delay may come into play, regardless of the number of packets ack-eliciting ```suggestion delay may come into play, regardless of the number of ack-eliciting ``` > @@ -436,9 +436,9 @@ conditions: PTO SHOULD be scheduled for min(RTO, PTO). QUIC includes MaxAckDelay in all probe timeouts, because it assumes the ack -delay may come into play, regardless of the number of packets outstanding. -TCP's TLP assumes if at least 2 packets are outstanding, acks will not be -delayed. +delay may come into play, regardless of the number of packets ack-eliciting +packets in-flight. TCP's TLP assumes if at least 2 ack-eliciting packets are +in-flight, acks will not be delayed. ```suggestion in flight, acks will not be delayed. ``` > @@ -796,7 +796,7 @@ Pseudocode for SetLossDetectionTimer follows: loss_detection_timer.cancel() return - if (crypto packets are outstanding): + if (crypto packets are in-flight): ```suggestion if (crypto packets are in flight): ``` > @@ -837,7 +837,7 @@ Pseudocode for OnLossDetectionTimeout follows: ~~~ OnLossDetectionTimeout(): - if (crypto packets are outstanding): + if (crypto packets are in-fight): ```suggestion if (crypto packets are in flight): ``` > @@ -1043,7 +1043,7 @@ kMaxDatagramSize: windows. The RECOMMENDED value is 1200 bytes. kInitialWindow: -: Default limit on the initial amount of outstanding data in bytes. Taken from +: Default limit on the initial amount of in-flight data in bytes. Taken from ```suggestion : Default limit on the initial amount of data in flight, in bytes. Taken from ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2120#pullrequestreview-184436678
- [quicwg/base-drafts] In-flight not outstanding (#… ianswett
- Re: [quicwg/base-drafts] In-flight not outstandin… janaiyengar
- Re: [quicwg/base-drafts] In-flight not outstandin… ianswett
- Re: [quicwg/base-drafts] In-flight not outstandin… ianswett
- Re: [quicwg/base-drafts] In-flight not outstandin… ianswett
- Re: [quicwg/base-drafts] In-flight not outstandin… ianswett
- Re: [quicwg/base-drafts] In-flight not outstandin… ianswett
- Re: [quicwg/base-drafts] In-flight not outstandin… ianswett
- Re: [quicwg/base-drafts] In-flight not outstandin… ianswett
- Re: [quicwg/base-drafts] In-flight not outstandin… ianswett
- Re: [quicwg/base-drafts] In-flight not outstandin… janaiyengar