Re: [quicwg/base-drafts] Update ACK generation policy (#3623)

Martin Thomson <notifications@github.com> Mon, 04 May 2020 04:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2498B3A0C08 for <quic-issues@ietfa.amsl.com>; Sun, 3 May 2020 21:53:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bGduQJDU70ob for <quic-issues@ietfa.amsl.com>; Sun, 3 May 2020 21:53:48 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 424CC3A0C07 for <quic-issues@ietf.org>; Sun, 3 May 2020 21:53:48 -0700 (PDT)
Received: from github-lowworker-2ef7ba1.ac4-iad.github.net (github-lowworker-2ef7ba1.ac4-iad.github.net [10.52.16.66]) by smtp.github.com (Postfix) with ESMTP id E96C19604FE for <quic-issues@ietf.org>; Sun, 3 May 2020 21:53:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1588568026; bh=OOKsuOGIO3P56Mj8kpsNzKY+2+mybOs94mVeZBBqaDg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CcXWkluJ3k4WeALo0Sw8lhGbjp2djQfv8NQ2NxGqSv308bi5DhIgVzg3C/LJXXhDq 5xkulkkhS5lgNvSH8lCb+Na48GkrPT4t6S5b7R0ewGEBQIVNy2a9e9RJne+VhLoMC9 GvogjKiH7OVbpFtUNeUkvQVE7BPYzHi3DhlHAOO8=
Date: Sun, 03 May 2020 21:53:46 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK56OEUMXBTIJZJKK4F4XOANVEVBNHHCIZ5LBI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3623/review/404708350@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3623@github.com>
References: <quicwg/base-drafts/pull/3623@github.com>
Subject: Re: [quicwg/base-drafts] Update ACK generation policy (#3623)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eaf9fdad9583_47fb3f9139ecd95c456bc"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/J-vcxJT_QOemLRmFMQcVv99qhM8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 May 2020 04:53:50 -0000

@martinthomson commented on this pull request.

Copyedit only.  I'll let this debate continue.

> @@ -3261,8 +3261,14 @@ a max_ack_delay of 0 is used. The sender uses the receiver's `max_ack_delay`
 value in determining timeouts for timer-based retransmission, as detailed in
 Section 5.2.1 of {{QUIC-RECOVERY}}.
 
-An ACK frame SHOULD be generated for at least every second ack-eliciting packet.
-This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
+

```suggestion
```

> @@ -3261,8 +3261,14 @@ a max_ack_delay of 0 is used. The sender uses the receiver's `max_ack_delay`
 value in determining timeouts for timer-based retransmission, as detailed in
 Section 5.2.1 of {{QUIC-RECOVERY}}.
 
-An ACK frame SHOULD be generated for at least every second ack-eliciting packet.
-This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
+
+An ACK frame SHOULD be generated for at least every 10th ack-eliciting packet
+(the QUIC IW). A receiver could send an ACK frame at least every second 
+ack-elicitingpacket (recommended practice for TCP {{?RFC5681}}). QUIC permits 

```suggestion
ack-eliciting packet (recommended practice for TCP {{?RFC5681}}). QUIC permits 
```

> @@ -3261,8 +3261,14 @@ a max_ack_delay of 0 is used. The sender uses the receiver's `max_ack_delay`
 value in determining timeouts for timer-based retransmission, as detailed in
 Section 5.2.1 of {{QUIC-RECOVERY}}.
 
-An ACK frame SHOULD be generated for at least every second ack-eliciting packet.
-This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
+
+An ACK frame SHOULD be generated for at least every 10th ack-eliciting packet
+(the QUIC IW). A receiver could send an ACK frame at least every second 
+ack-elicitingpacket (recommended practice for TCP {{?RFC5681}}). QUIC permits 
+a larger ratio between ACKs and data,which can reduce

```suggestion
a larger ratio between ACKs and data, which can reduce
```

> @@ -3261,8 +3261,14 @@ a max_ack_delay of 0 is used. The sender uses the receiver's `max_ack_delay`
 value in determining timeouts for timer-based retransmission, as detailed in
 Section 5.2.1 of {{QUIC-RECOVERY}}.
 
-An ACK frame SHOULD be generated for at least every second ack-eliciting packet.
-This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
+
+An ACK frame SHOULD be generated for at least every 10th ack-eliciting packet
+(the QUIC IW). A receiver could send an ACK frame at least every second 
+ack-elicitingpacket (recommended practice for TCP {{?RFC5681}}). QUIC permits 
+a larger ratio between ACKs and data,which can reduce
+the number of ACK frames that are sent and need to be processed.
+The receiver can provide a higher rate of acknowledgements
+(e.g. every ack-eliciting packet) for the first 100 packets.

```suggestion
(e.g., every ack-eliciting packet) for the first 100 packets.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3623#pullrequestreview-404708350