Re: [quicwg/base-drafts] SHOULD NOT include platform delay in ack delay (#2786)

Kazuho Oku <notifications@github.com> Fri, 14 June 2019 00:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AA6D1120096 for <quic-issues@ietfa.amsl.com>; Thu, 13 Jun 2019 17:57:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KE2iANKGo_I5 for <quic-issues@ietfa.amsl.com>; Thu, 13 Jun 2019 17:57:39 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD76E12000E for <quic-issues@ietf.org>; Thu, 13 Jun 2019 17:57:39 -0700 (PDT)
Date: Thu, 13 Jun 2019 17:57:38 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560473858; bh=BGjCOxpAkucQdOArtDkPnjEuKpkU9DSont3pZtcHCU8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xapfU0pSp5+n6jtP8txVaR5mHC8KCqmk9dQ9G6QlglHmiuynyZatt7zn5YWA5t3c3 rIuzqg+gI1vm7TCHNxL1XSkdtd1PHHPVkxaan3B45o66fjV9AQnd8DR6vJUfVFMUuL m8CuZ1FaiNJcfaJYQoDMWU35/FurjLYSJR0IVudE=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7CBCC2JWMFJ4DBYTN3CARYFEVBNHHBWJS6WM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2786/review/249669670@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2786@github.com>
References: <quicwg/base-drafts/pull/2786@github.com>
Subject: Re: [quicwg/base-drafts] SHOULD NOT include platform delay in ack delay (#2786)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d02f102a1855_efa3fac0bccd96c109891"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KA-dF3hLJhulN81-CCTxBY7H5ic>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jun 2019 00:57:42 -0000

kazuho commented on this pull request.



> @@ -302,15 +302,15 @@ continue making forward progress.
 
 ## Measuring and Reporting Host Delay {#host-delay}
 
-An endpoint measures the delay incurred between when a packet is received and
-when the corresponding acknowledgment is sent.  The endpoint encodes this host
-delay for the largest acknowledged packet in the Ack Delay field of an ACK frame
-(see Section 19.3 of {{QUIC-TRANSPORT}}).  This allows the receiver of the ACK
-to adjust for any host delays, which is important for delayed acknowledgements,
-when estimating the path RTT.  In certain deployments, a packet might be held in
-the OS kernel or elsewhere on the host before being processed by the QUIC
-stack. Where possible, an endpoint MAY include these delays when populating the
-Ack Delay field in an ACK frame.
+An endpoint measures the intentional delay between when a ACK-eliciting packet

_an_ ACK-eliciting packet?

> -delay for the largest acknowledged packet in the Ack Delay field of an ACK frame
-(see Section 19.3 of {{QUIC-TRANSPORT}}).  This allows the receiver of the ACK
-to adjust for any host delays, which is important for delayed acknowledgements,
-when estimating the path RTT.  In certain deployments, a packet might be held in
-the OS kernel or elsewhere on the host before being processed by the QUIC
-stack. Where possible, an endpoint MAY include these delays when populating the
-Ack Delay field in an ACK frame.
+An endpoint measures the intentional delay between when a ACK-eliciting packet
+is received and the corresponding acknowledgment is sent. The endpoint encodes
+this delay for the largest acknowledged packet in the Ack Delay field of an ACK
+frame (see Section 19.3 of {{QUIC-TRANSPORT}}).  This allows the receiver of the
+ACK to adjust for any intentional delays, which is important for delayed
+acknowledgements, when estimating the path RTT.  A packet might be held in the
+OS kernel or elsewhere on the host before being processed.  An endpoint
+SHOULD NOT include these delays when populating the Ack Delay field in an ACK
+frame.

Do we need to state something like "unless the delay is controlled by the stack"?

I ask this, because I'd assume that the delay should be taken into account even if it is introduced by the kernel or elsewhere, if it is "intentional" by the stack.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2786#pullrequestreview-249669670