Re: [quicwg/base-drafts] Unilateral Transport Parameters (#3478)

ianswett <notifications@github.com> Mon, 24 February 2020 14:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3FC03A0CD4 for <quic-issues@ietfa.amsl.com>; Mon, 24 Feb 2020 06:59:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id myg_JCpIMtXB for <quic-issues@ietfa.amsl.com>; Mon, 24 Feb 2020 06:59:18 -0800 (PST)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2E61B3A0CCA for <quic-issues@ietf.org>; Mon, 24 Feb 2020 06:59:18 -0800 (PST)
Received: from github-lowworker-e8b54ca.ac4-iad.github.net (github-lowworker-e8b54ca.ac4-iad.github.net [10.52.23.39]) by smtp.github.com (Postfix) with ESMTP id 3E56D6E0E4B for <quic-issues@ietf.org>; Mon, 24 Feb 2020 06:59:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582556357; bh=i9qQhVM6OTSFkcr1/pCY3UO06tArmb/mU7yzjwjhRDQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=lQV94pXvJsNgXRg6C0RE+pGL8Wd3EPsju4E2K8DSAZMZ+df1108TqBTROtd0z/ekM Be9oB9hwI/q3VAsCa3PbYU8xo/LYC76QNb/DRycSo25ygFrgikb6mgeARB2BvJdLSQ TeynCP4V7txdBgGrJyvI2gd8Th4N6z2hLmhT+OL8=
Date: Mon, 24 Feb 2020 06:59:17 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4KVE4LK3HIHAWYUPF4MELULEVBNHHCD4D5FY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3478/review/363451275@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3478@github.com>
References: <quicwg/base-drafts/pull/3478@github.com>
Subject: Re: [quicwg/base-drafts] Unilateral Transport Parameters (#3478)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e53e4c52ea99_793b3fc96d0cd96c192075"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/MbwlVP1Y_hBvIzkZgHYtfTVpGqY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Feb 2020 14:59:26 -0000

ianswett commented on this pull request.



> @@ -1486,6 +1485,10 @@ QUIC includes the encoded transport parameters in the cryptographic handshake.
 Once the handshake completes, the transport parameters declared by the peer are
 available.  Each endpoint validates the value provided by its peer.
 
+Transport parameters are declarations that are made unilaterally by each

I'd prefer this two paragraphs up closer to where it was.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3478#pullrequestreview-363451275