Re: [quicwg/base-drafts] Brian Kaduk's nits on HTTP/3 (#4810)

Martin Thomson <notifications@github.com> Mon, 25 January 2021 06:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 71F1A3A0AA1 for <quic-issues@ietfa.amsl.com>; Sun, 24 Jan 2021 22:48:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.45
X-Spam-Level:
X-Spam-Status: No, score=-1.45 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z_9FwoALHlrT for <quic-issues@ietfa.amsl.com>; Sun, 24 Jan 2021 22:48:33 -0800 (PST)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9F48D3A0A9E for <quic-issues@ietf.org>; Sun, 24 Jan 2021 22:48:33 -0800 (PST)
Received: from github.com (hubbernetes-node-018b4c5.ash1-iad.github.net [10.56.117.56]) by smtp.github.com (Postfix) with ESMTPA id C0F1A9026E5 for <quic-issues@ietf.org>; Sun, 24 Jan 2021 22:48:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1611557312; bh=8h6DsDUDxYbSHJQJCF2asPjP1EKh/kTY3oEYB4Urig0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NJh1lQ3qz2G2WNUpumKhf5ZdtgEM991gMSyPuSlkv7FKE7T29lYf8iuFep28R/1Me 3eUP5vZGkWcMGzqHfuRRx5iYoTUj+6YP2CeufuQTPe8j3zcQu6QfLSHH6Ik/S+PJ0u ZvR5EynaUBYYvTloMiiyxAdQgcdm1I302ZcaZ07U=
Date: Sun, 24 Jan 2021 22:48:32 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6LNG7Y55FMOB32NFN6DJFMBEVBNHHC6OK4AM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4810/review/575100683@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4810@github.com>
References: <quicwg/base-drafts/pull/4810@github.com>
Subject: Re: [quicwg/base-drafts] Brian Kaduk's nits on HTTP/3 (#4810)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_600e69c0be6a8_20c11a04196517"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/N6k18KheTCO03DZ2iJyRatap9fU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jan 2021 06:48:36 -0000

@martinthomson commented on this pull request.

One change here looks a little off.

> @@ -1908,13 +1920,13 @@ A client can discard responses that it cannot process.
 
 ### CONNECT Issues
 
-The CONNECT method can be used to create disproportionate load on a proxy,
-since stream creation is relatively inexpensive when compared to the creation
-and maintenance of a TCP connection.  A proxy might also maintain some resources
-for a TCP connection beyond the closing of the stream that carries the CONNECT
+The CONNECT method can be used to create disproportionate load on a proxy, since

```suggestion
The CONNECT method can be used to create disproportionate load on a proxy, as
```

> +Therefore, a proxy might delay increasing the QUIC stream limits to account for
+the resources consumed by CONNECT requests.

The original text existed to note that accounting for streams as requests is insufficient in the case that a CONNECT request is used.  Delay does no good.  What we might instead say is that any proxy that supports CONNECT might choose to limit the number of concurrent CONNECT streams it accepts (and account for the higher cost of those streams when considering overall resource allocation).

> @@ -2267,6 +2286,10 @@ of time.  HTTP/3 servers might choose to permit a larger number of concurrent
 client-initiated bidirectional streams to achieve equivalent concurrency to
 HTTP/2, depending on the expected usage patterns.
 
+In HTTP/2, only request and response bodies (DATA frames) are subject to flow

```suggestion
In HTTP/2, only request and response bodies (the frame payload of DATA frames) are subject to flow
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4810#pullrequestreview-575100683