Re: [quicwg/base-drafts] Clarify coalesced packet processing (#1844)

Mike Bishop <notifications@github.com> Tue, 09 October 2018 19:34 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 27C9112D7F8 for <quic-issues@ietfa.amsl.com>; Tue, 9 Oct 2018 12:34:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.455
X-Spam-Level:
X-Spam-Status: No, score=-3.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bBxa5YBKuBgA for <quic-issues@ietfa.amsl.com>; Tue, 9 Oct 2018 12:34:35 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B050129619 for <quic-issues@ietf.org>; Tue, 9 Oct 2018 12:34:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=qHztd6PZHEGEZJ/CX3FH/LWJb0o=; b=tSxT51kzXPi4lay+ 27C8DSnNfqZ9wEkDwryt6vOoVqi912o6vv0hD5E1sGgv8v94jwcKUpKIwQiLjmr3 FvSJhnwGppAcUd6QGBUrRKBRiCq5QmGBDGqZg9hTPYdgTqrknevTeucBNdJ4oJrQ 6YrxILLjl6uyKqrWbKEJ/Tw/GV0=
Received: by filter1735p1mdw1.sendgrid.net with SMTP id filter1735p1mdw1-31692-5BBD02C9-15 2018-10-09 19:34:33.463087243 +0000 UTC m=+37107.587423950
Received: from github-lowworker-89d05ac.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id 24nuW4uQTH6UrTbUm9h0tQ for <quic-issues@ietf.org>; Tue, 09 Oct 2018 19:34:33.338 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-89d05ac.cp1-iad.github.net (Postfix) with ESMTP id 502D6AE031D for <quic-issues@ietf.org>; Tue, 9 Oct 2018 12:34:33 -0700 (PDT)
Date: Tue, 09 Oct 2018 19:34:33 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab96eb57b6c41fb621addc8b460e499b19a4d2d67b92cf0000000117d4c4c992a169ce15eeeab1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1844/review/163060172@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1844@github.com>
References: <quicwg/base-drafts/pull/1844@github.com>
Subject: Re: [quicwg/base-drafts] Clarify coalesced packet processing (#1844)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bbd02c94cf7d_23533fb0e88d45b813911"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2Y8Lj4/sMys1Bf6TBno2SNvIu3ToUbwvIxfj JjJPOkfQm/H/gEGrBgeRi4x8Wf+hNBlrxQyQgH4nV4dYMTDMhNVzbCjDdaVt6GJ9dR8uZb+PrrWvBY LZVLF8/wpwZYNsI6Ayxh2N7VW1zHeTdPTLuzftCyeC1fJKaONRcsIU00hCricM/FK4Jt3ZwcGLgQRE s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NEd1VS-cMl6IA6d1ub0bhuwJOf0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Oct 2018 19:34:37 -0000

MikeBishop commented on this pull request.



> @@ -960,12 +960,10 @@ Every QUIC packet that is coalesced into a single UDP datagram is separate and
 complete.  Though the values of some fields in the packet header might be
 redundant, no fields are omitted.  The receiver of coalesced QUIC packets MUST
 individually process each QUIC packet and separately acknowledge them, as if
-they were received as the payload of different UDP datagrams.  If one or more
-packets in a datagram cannot be processed yet (because the keys are not yet
-available) or processing fails (decryption failure, unknown type, etc.), the
-receiver MUST still attempt to process the remaining packets.  The skipped
-packets MAY either be discarded or buffered for later processing, just as if the
-packets were received out-of-order in separate datagrams.
+they were received as the payload of separate UDP datagrams.  For example, if
+decryption fails or the packet is of an unknown type, the receiver MAY either

This seems to lose the case this text was originally added to address, which is that you don't have the keys to process this packet type yet.  While these are non-limiting examples, that's probably a case worth calling out explicitly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1844#pullrequestreview-163060172