Re: [quicwg/base-drafts] Stop requiring remote address to match during path validation (#2637)

Eric Kinnear <notifications@github.com> Wed, 01 May 2019 20:51 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AE96D12013C for <quic-issues@ietfa.amsl.com>; Wed, 1 May 2019 13:51:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nq_7panXqNaR for <quic-issues@ietfa.amsl.com>; Wed, 1 May 2019 13:51:01 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90344120021 for <quic-issues@ietf.org>; Wed, 1 May 2019 13:51:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=tHneD/eNUqRUfhX9xdRh2k559Gw=; b=fW2eE8oHw7KCcG1M 5Gmm3p+4+GaGu2hxQm0ECPNwNBuTzxhdZ1EKKvJbyl1cotLQ+Vb0v5Jqg0NmEARy 0Xlg4vYZgIJ916UiW6udeKvrbz0ApZRaMIPYb/9FEAUAePtOlizUYQIJWjESpF1u f8zo0ohUzAZEbb3unK8UJAJpva4=
Received: by filter0203p1iad2.sendgrid.net with SMTP id filter0203p1iad2-32218-5CCA06B4-7 2019-05-01 20:51:00.042034535 +0000 UTC m=+515602.629460549
Received: from github-lowworker-89d05ac.cp1-iad.github.net (unknown [140.82.115.66]) by ismtpd0031p1iad2.sendgrid.net (SG) with ESMTP id 5o5H1uzlSVu5ygfppTDPOw for <quic-issues@ietf.org>; Wed, 01 May 2019 20:51:00.020 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-89d05ac.cp1-iad.github.net (Postfix) with ESMTP id ECF7CAE0247 for <quic-issues@ietf.org>; Wed, 1 May 2019 13:50:59 -0700 (PDT)
Date: Wed, 01 May 2019 20:51:00 +0000 (UTC)
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4UH2FXSOLJ33ICXTV2244THEVBNHHBT4WDAY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2637/review/232750883@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2637@github.com>
References: <quicwg/base-drafts/pull/2637@github.com>
Subject: Re: [quicwg/base-drafts] Stop requiring remote address to match during path validation (#2637)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cca06b3eafec_41cb3faa366cd96c27125a"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2KfKo+NQcRvZjAPkOewbWgnuQbCYPioRTrDY Ppo7bF9sAQVFACJ7xt50EBJjR2cQqgx1GnBYA6PcQyuHqcWYzmn5YCnxPFU4jG1a96gH/YJhCoOTs3 gbRvHIu92bWk7QqdXuIv0S6aNV+EBtqWH0ewDqeh+Hg6dKJkM/ueeR3iDbKh3WuX/iVKvGz0i3b6ZD 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NuUqf4VuL5R-oLkREus_ou7eOts>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 May 2019 20:51:04 -0000

erickinnear commented on this pull request.



> @@ -1714,12 +1714,6 @@ meets the following criteria:
   acknowledgment for a packet containing a PATH_CHALLENGE frame is not adequate
   validation, since the acknowledgment can be spoofed by a malicious peer.
 
-- It was sent from the same remote address to which the corresponding
-  PATH_CHALLENGE was sent. If a PATH_RESPONSE frame is received from a different
-  remote address than the one to which the PATH_CHALLENGE was sent, path
-  validation is considered to have failed, even if the data matches that sent in
-  the PATH_CHALLENGE.
-
 - It was received on the same local address from which the corresponding
   PATH_CHALLENGE was sent.

Makes sense, thanks! Will add.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2637#discussion_r280211502