Re: [quicwg/base-drafts] transport: fix dangling ref to recovery (#2853)
Julian Reschke <notifications@github.com> Thu, 27 June 2019 06:07 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F285A1200FF for <quic-issues@ietfa.amsl.com>; Wed, 26 Jun 2019 23:07:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.595
X-Spam-Level:
X-Spam-Status: No, score=-6.595 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0HoMiNvAHaJ7 for <quic-issues@ietfa.amsl.com>; Wed, 26 Jun 2019 23:07:38 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3979A1200F5 for <quic-issues@ietf.org>; Wed, 26 Jun 2019 23:07:38 -0700 (PDT)
Date: Wed, 26 Jun 2019 23:07:37 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561615657; bh=e+QTMSxVhD+YOhg6Armv0NvB74vApX/4JJWwX22riX4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tm62SOByD2lbdaaEg/qKjmvgaTAaCmJgCSXDV9J5deRDrNA1ocMn+bP9+fQ4X+TIO d2vTSfotMjdAC1SM5SoQWfbax9Us1yXsgas5CRvM8+NbGUIe5z+IYIzSGB5RM9F0fW d8bxr7dCN1KKXPHu+Plcwfy5ndNN4Lr6NHS5AHSg=
From: Julian Reschke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4UMXFUFTEKUJR7GYN3EGH2TEVBNHHBW72DLE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2853/review/255021055@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2853@github.com>
References: <quicwg/base-drafts/pull/2853@github.com>
Subject: Re: [quicwg/base-drafts] transport: fix dangling ref to recovery (#2853)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d145d29518b_7f453fda136cd96472542"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: reschke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/O926F299f7h23YcrJpSo_CAJAuc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Jun 2019 06:07:40 -0000
reschke commented on this pull request.
> @@ -2924,7 +2924,7 @@ messages are delayed or lost. Note that the same limitation applies to other
data sent by the server protected by the 1-RTT keys.
Endpoints SHOULD send acknowledgments for packets containing CRYPTO frames with
-a reduced delay; see Section 6.2.1 of {{QUIC-RECOVERY}}.
+a reduced delay; see Section 6.4 of {{QUIC-RECOVERY}}.
No, I think the change is correct. See <https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-13.1.2> and <https://tools.ietf.org/html/draft-ietf-quic-recovery-20#section-6.2.1>.
(FWIW, it would be good if these checks could be made part of the toolset used for the build)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2853#discussion_r298019209
- [quicwg/base-drafts] transport: fix dangling ref … Julian Reschke
- Re: [quicwg/base-drafts] transport: fix dangling … Martin Thomson
- Re: [quicwg/base-drafts] transport: fix dangling … Julian Reschke
- Re: [quicwg/base-drafts] transport: fix dangling … Martin Thomson
- Re: [quicwg/base-drafts] transport: fix dangling … Martin Thomson
- Re: [quicwg/base-drafts] transport: fix dangling … Martin Thomson