Re: [quicwg/base-drafts] Don't Change Source CID After Retry (#1491)

Kazuho Oku <notifications@github.com> Wed, 27 June 2018 21:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C22F7130E34 for <quic-issues@ietfa.amsl.com>; Wed, 27 Jun 2018 14:57:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kdmop2HyIsmG for <quic-issues@ietfa.amsl.com>; Wed, 27 Jun 2018 14:57:21 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 93DC2124BE5 for <quic-issues@ietf.org>; Wed, 27 Jun 2018 14:57:21 -0700 (PDT)
Date: Wed, 27 Jun 2018 14:57:20 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530136640; bh=YgqJ6brLsi+ITVCtLBaadfw0fVoUjFaaSksXx2T8XYk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uCAMKIKahKylcntCdKIMS0BqmMcLR6bE1XG+iWWeVQKt08mRnJfo/+x0aOj+5q//T QPm6MsZwqu1UshW/6aMzVOictnHOQpDjBpESOlzPmr4glt4ZB+T+kmuT7LSHYyQhCN Kv+CuGZ4+68eLok3bpwYUfnEsJIMHdsc0F6R+BJc=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc9793cc12314fcdac3ce35ace2e5c8afaa8dfd4b92cf00000001174bca4092a169ce140bc75e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1491/c400842078@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1491@github.com>
References: <quicwg/base-drafts/pull/1491@github.com>
Subject: Re: [quicwg/base-drafts] Don't Change Source CID After Retry (#1491)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b340840c8111_3dd63faf17cb4f84884bf"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OdDhVCcakyutfevUzf-3PuI4QMs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jun 2018 21:57:24 -0000

@MikeBishop 
> I thought there was text to the effect that changing the SCID during the handshake was effectively starting a fresh connection attempt, but I don't see it in the draft. 

FWIW, my understanding is that the existing text is (emphasis mine):
> During the handshake, an endpoint might receive multiple packets with the long header, and thus be given multiple opportunities to update the Destination Connection ID it sends. A client MUST only change the value it sends in the Destination Connection ID in response to the first packet of each type it receives from the server (Retry or Initial); **a server MUST set its value based on the Initial packet. Any additional changes are not permitted; if subsequent packets of those types include a different Source Connection ID, they MUST be discarded.** This avoids problems that might arise from stateless processing of multiple Initial packets producing different connection IDs.
> [4.7 Connection ID Encoding](https://quicwg.org/base-drafts/draft-ietf-quic-transport.html#connection-id-encoding)

Anyways I agree that this is written from server's viewpoint, and I agree that we should have a "MUST NOT" for the client.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1491#issuecomment-400842078