IETF Logo Mail Archive

Re: [quicwg/base-drafts] Cherry-pick from Ekr's WGLC edits (#3901)

Jana Iyengar <notifications@github.com> Tue, 14 July 2020 22:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6C3A13A0BDD for <quic-issues@ietfa.amsl.com>; Tue, 14 Jul 2020 15:51:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.483
X-Spam-Level:
X-Spam-Status: No, score=-6.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BQZa2z_EEvqO for <quic-issues@ietfa.amsl.com>; Tue, 14 Jul 2020 15:51:52 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 366533A0AE9 for <quic-issues@ietf.org>; Tue, 14 Jul 2020 15:51:49 -0700 (PDT)
Received: from github-lowworker-cd7bc13.ac4-iad.github.net (github-lowworker-cd7bc13.ac4-iad.github.net [10.52.25.102]) by smtp.github.com (Postfix) with ESMTP id 85B60660120 for <quic-issues@ietf.org>; Tue, 14 Jul 2020 15:51:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594767108; bh=mb69w241Rz/gl6sniJnqj/JbFVtTYQGJvoL4viC4eo4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ztqrH0evnvWRXcMlgDp46Xak9fKATndy4JD6P06cOZCX2veNUed2DNUjm3jdIoIKm sCJ8Y5aAuXhZFsQaJRXcsQ/xfRuLoDL8dGRq1XcHumEhyYHkgHLrSOfZav/d/iD3TA VUAPOvCBsJCsxnTMoF4aYYHcH3eCLFs3o9f5LWog=
Date: Tue, 14 Jul 2020 15:51:48 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2P2REGM2ENINFKZP55DIMAJEVBNHHCOH4RQI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3901/review/448516300@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3901@github.com>
References: <quicwg/base-drafts/pull/3901@github.com>
Subject: Re: [quicwg/base-drafts] Cherry-pick from Ekr's WGLC edits (#3901)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f0e370476e42_2f203f7e1fecd95c315413"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Rm1G8456rgJnDUODRwG4_qG9mVs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2020 22:52:00 -0000

@janaiyengar approved this pull request.

one nit, but LGTM

>  A receiver sets initial limits for all streams by sending transport parameters
 during the handshake ({{transport-parameters}}).  A receiver sends
 MAX_STREAM_DATA ({{frame-max-stream-data}}) or MAX_DATA ({{frame-max-data}})
 frames to the sender to advertise larger limits.
 
 A receiver can advertise a larger limit for a stream by sending a
-MAX_STREAM_DATA frame with the Stream ID field set appropriately. A
+MAX_STREAM_DATA frame with a corresponding Stream ID field. A

```suggestion
MAX_STREAM_DATA frame with the corresponding stream ID. A
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3901#pullrequestreview-448516300

v2.23.0 | Report a Bug | By Email