Re: [quicwg/base-drafts] Should QPACK use the new layout? (#3999)

Mike Bishop <notifications@github.com> Tue, 25 August 2020 15:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CADAE3A0E37 for <quic-issues@ietfa.amsl.com>; Tue, 25 Aug 2020 08:19:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.501
X-Spam-Level:
X-Spam-Status: No, score=-0.501 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qvsS6S3j5Q2S for <quic-issues@ietfa.amsl.com>; Tue, 25 Aug 2020 08:19:30 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9F4523A0E3D for <quic-issues@ietf.org>; Tue, 25 Aug 2020 08:19:30 -0700 (PDT)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id E587D600E10 for <quic-issues@ietf.org>; Tue, 25 Aug 2020 08:19:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598368769; bh=PmlWd07g1pT5E7iW0AL9GEeXW5y6ydyNWj42rrkwQNQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=aoQTJV5edp7jmz/pgwC42dHXU7Wys1pt6MdU1KvlQ30BSJR4PRiU5hPMQUoxTnr3Z P1Ydw0t56DN7aBpCqYir7lTRNV3jm6qJlkX7O18QtfhUxu58e1gOdr+OxNzTMkG314 47WZpFMo3uevm73aOrp5327YxRO9g4JGnk90mtSQ=
Date: Tue, 25 Aug 2020 08:19:29 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYBJHMYAXC5MOXDZ6V5KEGQDEVBNHHCQ7UHAM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3999/680090993@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3999@github.com>
References: <quicwg/base-drafts/issues/3999@github.com>
Subject: Re: [quicwg/base-drafts] Should QPACK use the new layout? (#3999)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f452c01d578e_242b19641984ea"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/S7qIWYJ8G3iluh6p-jJKS4tmbho>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Aug 2020 15:19:32 -0000

Personally, the "nonsense" of a byte grid doesn't bother me as much with H/QPACK as with others, and I think I've figured out why:

- Things are presented one byte at a time instead of four bytes at a time.
- Prefixed integers will take up the indicated portion of a byte if they fit, but might spill over to additional bytes which come before the next byte shown.
- QUIC fields were presented four bytes at a time, containing varints which messed with four-byte alignment, so the byte grid never made sense.

I kind of wish there were a better way of indicating visually where these possible extra bytes would fall (=== vs. ---?) but the + in the field length is a strong clue.  If folks think the old format is better to stay in sync with HPACK, that's fine -- I just wanted to have the PR and make sure it was a decision instead of inertia.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3999#issuecomment-680090993