Re: [quicwg/base-drafts] Bundle new client connection ID and path challenge in migration probes (#1730)

Christian Huitema <notifications@github.com> Mon, 10 September 2018 04:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F1172130E65 for <quic-issues@ietfa.amsl.com>; Sun, 9 Sep 2018 21:56:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ztcNa96TFHXx for <quic-issues@ietfa.amsl.com>; Sun, 9 Sep 2018 21:56:53 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 60DD4130E4D for <quic-issues@ietf.org>; Sun, 9 Sep 2018 21:56:53 -0700 (PDT)
Date: Sun, 09 Sep 2018 21:56:52 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1536555412; bh=n6YC5rqnYbefxBQFWUb9l6eaJBX9m9XiR1Qiq1r3Y4s=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ti13xz1RGbDu7f8XWNzOJ4CDCtpI0assXx+dbUmBVtHpZKCGRoZ9qmP0zbRglkN2+ UC7qn4jmSQ9zQcsyiAoVfL2Xu7NRCz59oZXgh73GRGCF9oFBzmWJQpz8Td7aj6r3UB acIUSFezX6BxtZae2wG7sZw2Iq46HTg6FYi89TWE=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcb9d64d194950eb02604a78775f735b41db10b8592cf0000000117adbb9492a169ce155cc367@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1730/review/153624686@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1730@github.com>
References: <quicwg/base-drafts/pull/1730@github.com>
Subject: Re: [quicwg/base-drafts] Bundle new client connection ID and path challenge in migration probes (#1730)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b95f994b777f_657f3f9082ad45c410036c3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SInbpLD12873iFSpaK_4O6wbKL4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Sep 2018 04:56:57 -0000

huitema commented on this pull request.



> @@ -2187,7 +2190,10 @@ usable for this connection.  Failure to validate a path does not cause the
 connection to end unless there are no valid alternative paths available.
 
 An endpoint uses a new connection ID for probes sent from a new local address,
-see {{migration-linkability}} for further discussion.
+see {{migration-linkability}} for further discussion. An endpoint that uses
+a new local address should include a NEW_CONNECTION_ID frame in the probe,

Note that there is another issue in the same section. The text says that a packet containing PATH_CHALLENGE, PATH_RESPONSE, and PADDING frames is a "probing frame". Adding the NEW_CONNECTION_ID makes that a "non probing packet". I am not sure I fully get the consequences.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1730#discussion_r216197925