Re: [quicwg/base-drafts] Add CRYPTO_BUFFER_EXCEEDED to the error code table (#3012)
Marten Seemann <notifications@github.com> Tue, 10 September 2019 08:38 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CDEA61200A3 for <quic-issues@ietfa.amsl.com>; Tue, 10 Sep 2019 01:38:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S3sEhEraR9QH for <quic-issues@ietfa.amsl.com>; Tue, 10 Sep 2019 01:38:03 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 48A28120045 for <quic-issues@ietf.org>; Tue, 10 Sep 2019 01:38:03 -0700 (PDT)
Date: Tue, 10 Sep 2019 01:38:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568104682; bh=Dt2K7Re8bqIQEZOcmXPQ1khK5VqPT30y/3Zl/Au92qE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Gl4D3jVPwNAWhwx6Rblt9DQEITIvv7UYeeF7uSM72eKRTSrdr2+jP570w2ivntU5O 9v5lITmizdHslTLlxVLpophy7HvxHDnjcVHop845Bd1JrMTL1Ok19GWVroTmscxKNQ c8g0m4IpZNjG4sLVZDjlbLdWEFpmOaGn0rgwAKfM=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2PMBXYRUF5NOYL2S53QSJWVEVBNHHB2SR7IY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3012/review/285989152@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3012@github.com>
References: <quicwg/base-drafts/pull/3012@github.com>
Subject: Re: [quicwg/base-drafts] Add CRYPTO_BUFFER_EXCEEDED to the error code table (#3012)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d7760ea8a1e6_70cd3ff9532cd968338928"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UjZBw6H2MoVSsT9A790-kDNIlas>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Sep 2019 08:38:05 -0000
marten-seemann approved this pull request.
> @@ -5877,6 +5877,7 @@ The initial contents of this registry are shown in {{iana-error-table}}.
| 0x7 | FRAME_ENCODING_ERROR | Frame encoding error | {{error-codes}} |
| 0x8 | TRANSPORT_PARAMETER_ERROR | Error in transport parameters | {{error-codes}} |
| 0xA | PROTOCOL_VIOLATION | Generic protocol violation | {{error-codes}} |
+| 0xD | CRYPTO_BUFFER_EXCEEDED | CRYPTO data buffer overflowed | {{error-codes}} |
Not an issue with this PR, but I'm wondering if we should change the number to 0x9, in order to fill the gap.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3012#pullrequestreview-285989152
- [quicwg/base-drafts] Add CRYPTO_BUFFER_EXCEEDED t… Masakazu Kitajo
- Re: [quicwg/base-drafts] Add CRYPTO_BUFFER_EXCEED… Marten Seemann
- Re: [quicwg/base-drafts] Add CRYPTO_BUFFER_EXCEED… Martin Thomson