Re: [quicwg/base-drafts] Nits on QPACK (#4007)
afrind <notifications@github.com> Tue, 18 August 2020 22:38 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0393B3A0E87 for <quic-issues@ietfa.amsl.com>; Tue, 18 Aug 2020 15:38:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ELQhTEZFP37k for <quic-issues@ietfa.amsl.com>; Tue, 18 Aug 2020 15:38:07 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 525483A0E8B for <quic-issues@ietf.org>; Tue, 18 Aug 2020 15:37:35 -0700 (PDT)
Received: from github-lowworker-2ef7ba1.ac4-iad.github.net (github-lowworker-2ef7ba1.ac4-iad.github.net [10.52.16.66]) by smtp.github.com (Postfix) with ESMTP id A0D8D520D6E for <quic-issues@ietf.org>; Tue, 18 Aug 2020 15:37:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597790254; bh=JbypsXU89yGmDsOy0wrcJbWxHao2XYptlpY5T1oBnYw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xTUMWrNiIrwnBAFgFsFh92J/tLt3pWZ8Kaf4FpBfVDfzEbF1w97NfFwfReFMwi3TS pGOYSLwgwA/Fn8Kd1H5fhx5oqHuOmmjPAl6cYHLxhBquMVCd/Sus2W9UMAt05tlsJv TfiP5hxlNiGt9N6+4g+c8TVKmrXLNPixXZlxz+fc=
Date: Tue, 18 Aug 2020 15:37:34 -0700
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5GTAB4X5MOZIET3K55JA4S5EVBNHHCRDY7NA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4007/review/469876436@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4007@github.com>
References: <quicwg/base-drafts/pull/4007@github.com>
Subject: Re: [quicwg/base-drafts] Nits on QPACK (#4007)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3c582e902a2_6367196422572"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Z7uPJmFTd60OkFyAvVz8qB_6ayA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2020 22:38:09 -0000
@afrind commented on this pull request. > @@ -998,11 +994,12 @@ That is: A single-pass encoder determines the Base before encoding a field section. If the encoder inserted entries in the dynamic table while encoding the field -section, Required Insert Count will be greater than the Base, so the encoded -difference is negative and the sign bit is set to 1. If the field section was -not encoded using representations that reference the most recent entry in the -table and did not insert any new entries, the Base will be greater than the -Required Insert Count, so the delta will be positive and the sign bit is set to +section and is referencing them, Required Insert Count will be greater than the +Base, so the encoded difference is negative and the sign bit is set to 1. If +the field section was not encoded using representations that reference the most +recent entry in the table and did not insert any new entries, the Base will be +greater than the Required Insert Count, so the delta will be positive and the +sign bit is set to 0. This poor little 0 on a line by itself :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/4007#pullrequestreview-469876436