[quicwg/base-drafts] Collapse frame errors into HTTP_FRAME_ERROR (#2996)
Lucas Pardue <notifications@github.com> Wed, 28 August 2019 10:57 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CFA79120100 for <quic-issues@ietfa.amsl.com>; Wed, 28 Aug 2019 03:57:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZMd68xSLPtpA for <quic-issues@ietfa.amsl.com>; Wed, 28 Aug 2019 03:57:26 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E559F120105 for <quic-issues@ietf.org>; Wed, 28 Aug 2019 03:57:25 -0700 (PDT)
Date: Wed, 28 Aug 2019 03:57:24 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566989844; bh=macibWnEFMsuQnl30C1dYvNJ6ekvuUxjmgWjWV/gQtU=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=zpHmFOy68T+3NtWuXo8jorgpUWwtCOuC3fTCKVB6pbY1N8yr/RrZ63WLQeJBA7rHR Z/ViC0sqY40feO3Ljcir13Idk6IkBjCJjDrXB7WMcD1M24jXrNFya+0oeXuqWfxB64 rG9sRa06/cNmVi+nptrWn0lCcwdec3OJkIQPglKE=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2ETXBOLWTIB366OLV3OOPKJEVBNHHBZ7DTNU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2996@github.com>
Subject: [quicwg/base-drafts] Collapse frame errors into HTTP_FRAME_ERROR (#2996)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d665e14cb2b0_32ef3f8b856cd964108972"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZE61RRDiKTTxUcirNrCMCm5F3UA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Aug 2019 10:57:28 -0000
This is the most extreme form of fixing #2809, which was about rationalizing HTTP_WRONG_STREAM and HTTP_UNEXPECTED_FRAME. In a nutshell, what it means is that the same code is used when an endpoint that detects an error in the frame itself, or if the frame is on the wrong stream type or sent in the wrong direction. To paraphrase @MikeBishop slightly from the list discussion, this might be too much of a change for a protocol on the edge of late-stage process. Is this a clear improvement over what we have today (even if today is a bit clunky and requires a little extra code? I'm undecided but in the interest of resolving the conversation one way or the other I present this PR. You can view, comment on, or merge this pull request online at: https://github.com/quicwg/base-drafts/pull/2996 -- Commit Summary -- * replace HTTP_WRONG_STREAM and HTTP_UNEXPECTED_FRAME for HTTP_FRAME_ERROR -- File Changes -- M draft-ietf-quic-http.md (87) -- Patch Links -- https://github.com/quicwg/base-drafts/pull/2996.patch https://github.com/quicwg/base-drafts/pull/2996.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2996
- [quicwg/base-drafts] Collapse frame errors into H… Lucas Pardue
- Re: [quicwg/base-drafts] Collapse frame errors in… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Collapse frame errors in… Lucas Pardue
- Re: [quicwg/base-drafts] Collapse frame errors in… Kazuho Oku
- Re: [quicwg/base-drafts] Collapse frame errors in… ianswett
- Re: [quicwg/base-drafts] Collapse frame errors in… Lucas Pardue
- Re: [quicwg/base-drafts] Collapse frame errors in… Mike Bishop