[quicwg/base-drafts] infinite loop of OnLossDetectionTimeout (#3967)

Kazu Yamamoto <notifications@github.com> Wed, 29 July 2020 01:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A9D2D3A0906 for <quic-issues@ietfa.amsl.com>; Tue, 28 Jul 2020 18:40:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SxEn7EwUAOfP for <quic-issues@ietfa.amsl.com>; Tue, 28 Jul 2020 18:40:44 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DFED23A0E60 for <quic-issues@ietf.org>; Tue, 28 Jul 2020 18:40:14 -0700 (PDT)
Received: from github-lowworker-2ef7ba1.ac4-iad.github.net (github-lowworker-2ef7ba1.ac4-iad.github.net [10.52.16.66]) by smtp.github.com (Postfix) with ESMTP id 2AC37340E32 for <quic-issues@ietf.org>; Tue, 28 Jul 2020 18:40:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595986814; bh=W3WhV05UP4/aBE1JNcjeiPxa08yVa9G4VhX6eRqmddg=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=X90NzL93Il5U5TQqbFvnKV71ykuXsOb+ZxlW5ZkwGCwKmGlyJfu9ZMdkM0tCPCPeG kJO1jKxsjRQAHiedNxZx+cLcVgR1WB3qhGTCAuB5XkW09bCLsVM2jWVXm6TmAmXRSO OvfxsUm8wh0qrW1l99owOzxAxCPwtayFBiLIEsco=
Date: Tue, 28 Jul 2020 18:40:14 -0700
From: Kazu Yamamoto <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4ET2MXI2PDLGP6EA55FS2H5EVBNHHCPSIBZA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3967@github.com>
Subject: [quicwg/base-drafts] infinite loop of OnLossDetectionTimeout (#3967)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f20d37e19aff_3ed716f8715c3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZYy5gz857rqGon5vPHsawpgAjMA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2020 01:40:46 -0000

`OnLossDetectionTimeout` in the recovery draft always calls `SetLossDetectionTimer`, resulting in an infinite loop which continues even after the connection is closed. It would be nice if conditions such as `if (connection is open):` are added or comments are added.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3967