Re: [quicwg/base-drafts] always use "tls13 " prefix for Initial packets (#2032)

janaiyengar <notifications@github.com> Wed, 21 November 2018 23:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1762D130E3B for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 15:39:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3b67GvKsvDEW for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 15:39:42 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1DCB0130DF3 for <quic-issues@ietf.org>; Wed, 21 Nov 2018 15:39:42 -0800 (PST)
Date: Wed, 21 Nov 2018 15:39:41 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542843581; bh=4ipRFjWScxiSOerjmQK0hVFznlj4CmXbo/4ErE/HqzI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wd1JeG9x9c7htx1fcEGS+NHZ85l8ANAelr9whHhshyBZ69xzApSaor3kG3KMS0p+M XfE4pVPOwu4UPG6bR95lNhS2y9qJhh7PEeoNiSzdji5fsHOEUykkFpVSO2NhfFeMbQ tzJ+pLu9KRPOM5vEt4YxOPcZqUzcPbAn9l5SewzA=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab04761c000ade3b755fec08129340ab6cd5330b0d92cf00000001180daebd92a169ce16d380bd@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2032/review/177463199@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2032@github.com>
References: <quicwg/base-drafts/pull/2032@github.com>
Subject: Re: [quicwg/base-drafts] always use "tls13 " prefix for Initial packets (#2032)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf5ecbd3d00d_176d3f8a5e4d45b8202049"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_R1pjKbVPU6ci09oliCvsnPIvAw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Nov 2018 23:39:56 -0000

janaiyengar commented on this pull request.



> @@ -753,6 +753,10 @@ thus ensuring that the keys are different for each version of QUIC. This
 prevents a middlebox that only recognizes one version of QUIC from seeing or
 modifying the contents of handshake packets from future versions.
 
+The HKDF function defined in TLS 1.3 MUST be used even in case the minimum TLS
+version that the endpoint is willing to use is greater, so as to assure that
+the peer can decrypt the packet.

s/the packet/the Initial packet

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2032#pullrequestreview-177463199