[quicwg/base-drafts] Fix GOAWAY errors properly (#2713)
Mike Bishop <notifications@github.com> Thu, 16 May 2019 18:22 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0297512014A for <quic-issues@ietfa.amsl.com>; Thu, 16 May 2019 11:22:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4DPS2E-3KxM7 for <quic-issues@ietfa.amsl.com>; Thu, 16 May 2019 11:22:41 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 55692120072 for <quic-issues@ietf.org>; Thu, 16 May 2019 11:22:40 -0700 (PDT)
Date: Thu, 16 May 2019 11:22:36 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1558030956; bh=BkP2/iF0aoqIwaqaipxliqVxc9z5cx5PlE1nmME40Wc=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=dvEI6pEZoJfLD3fR87DzOXhIN4muQq70EwoXARgctxtwNIdgRxDFOfizk+QjHrt8J lmGhqgNpyN0Bsu9HAxwcTgjBOCAyuNV/C8mAow0GD6sJpPB7wNpLs4KA5PhuR0J8iY YtsEHrxRxku3Z41JwtAwPcZkb7Fs8iRn8NpjKH1g=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK27FI55TVH2V5EDVUN25LOOZEVBNHHBVB5BGI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2713@github.com>
Subject: [quicwg/base-drafts] Fix GOAWAY errors properly (#2713)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cddaa6c7146c_79183fdf904cd95c905424"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/a2o85nBBTllFNpgZ2MNRG0UtFNw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 May 2019 18:22:44 -0000
In #2705, @DaanDeMeyer correctly observed that I messed up #2343, but he closed his PR and I'm not able to reopen it without more git wizardry than I'm interested in practicing today. Easier just to fix it in my own branch. So: - GOAWAY properly sent by the server on the control stream, but *containing* the wrong stream ID can't be WRONG_STREAM, it should be MALFORMED_FRAME. - GOAWAY sent by the server on something other than the control frame isn't UNEXPECTED_FRAME, it's WRONG_STREAM (see [aside with @kazuho](https://github.com/quicwg/base-drafts/issues/2551#issuecomment-492911408) about whether the distinction actually matters, but in the interest of keeping the document internally consistent....) - GOAWAY sent by a client is UNEXPECTED_FRAME, and that's the only one I got right before. You can view, comment on, or merge this pull request online at: https://github.com/quicwg/base-drafts/pull/2713 -- Commit Summary -- * Fix GOAWAY errors properly this time -- File Changes -- M draft-ietf-quic-http.md (4) -- Patch Links -- https://github.com/quicwg/base-drafts/pull/2713.patch https://github.com/quicwg/base-drafts/pull/2713.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2713
- [quicwg/base-drafts] Fix GOAWAY errors properly (… Mike Bishop
- Re: [quicwg/base-drafts] Fix GOAWAY errors proper… Mike Bishop
- Re: [quicwg/base-drafts] Fix GOAWAY errors proper… Mike Bishop