IETF Logo Mail Archive

Re: [quicwg/base-drafts] Header protection mask for server Initial packet example from -tls A.3 seems incorrect (#4405)

Paul Mabileau <notifications@github.com> Tue, 24 November 2020 20:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B83343A0B6D for <quic-issues@ietfa.amsl.com>; Tue, 24 Nov 2020 12:59:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U9Y54UdTN74K for <quic-issues@ietfa.amsl.com>; Tue, 24 Nov 2020 12:59:23 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5CBFE3A0B62 for <quic-issues@ietf.org>; Tue, 24 Nov 2020 12:59:23 -0800 (PST)
Received: from github.com (hubbernetes-node-a1c7305.ac4-iad.github.net [10.52.100.50]) by smtp.github.com (Postfix) with ESMTPA id 95D7460059D for <quic-issues@ietf.org>; Tue, 24 Nov 2020 12:59:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1606251562; bh=uwOrgdxT3/p/D49nwG2un+wBhPn7byymCdZeJQ4psi4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Sv87lWi7DoH3Z5fkcCkmlnubU3jTbGbos+A37LO3Iv348EJ5vG8dOLIXalTLL3VIq wIfA/1Vo8006aYkcpkSIfdpwsibdwzxNThdf3yXm8UBRrl5bM8RbrF3RQZ8FBflNVy /yFR9N2UKu3gJqnrev5VGSJRuAEWKRrC7mxVw9P8=
Date: Tue, 24 Nov 2020 12:59:22 -0800
From: Paul Mabileau <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4IS2OUQVEIWA6UHRN5ZFKSVEVBNHHCZJWQWI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/4405/733229750@github.com>
In-Reply-To: <quicwg/base-drafts/issues/4405@github.com>
References: <quicwg/base-drafts/issues/4405@github.com>
Subject: Re: [quicwg/base-drafts] Header protection mask for server Initial packet example from -tls A.3 seems incorrect (#4405)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5fbd742a927d5_78819b4960c7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: PaulDance
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/c-5CU1BX-B93DWEm1k9ZuQMlr4s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2020 20:59:25 -0000

Investigated a bit more. Looking at the result of a `blame`, we can see that:

```blame
2ebdfd53a (Martin Thomson     2020-10-21 08:40:17 +1100 2214) sample = 823a5d24534d906ce4c76782a2167e34
6e9bfe065 (Martin Thomson     2020-06-04 14:39:25 +1000 2215) mask   = abaaf34fdc
2ebdfd53a (Martin Thomson     2020-10-21 08:40:17 +1100 2216) header = c7ff0000200008f067a5502a4262b5004075fb12
```

2ebdfd53a is indeed meant to update example vectors, while 2ebdfd53a is for other secrets, but the latter does is it completely.

```diff
 ~~~
-sample = 7002596f99ae67abf65a5852f54f58c3
-mask   = 38168a0c25
-header = c9ff00001d0008f067a5502a4262b5004074168b
+sample = 823a5d3a1207c86ee49132824f046524
+mask   = abaaf34fdc
+header = caff00001d0008f067a5502a4262b5004074aaf2
 ~~~
```

So it should confirm our hypothesis.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/4405#issuecomment-733229750

v2.23.0 | Report a Bug | By Email