Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806) (cb68286)
Jeremy Lainé <notifications@github.com> Wed, 17 July 2019 11:53 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DFD7F1202FC for <quic-issues@ietfa.amsl.com>; Wed, 17 Jul 2019 04:53:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.453
X-Spam-Level:
X-Spam-Status: No, score=-6.453 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.001, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xp1kqYr2cMpt for <quic-issues@ietfa.amsl.com>; Wed, 17 Jul 2019 04:53:32 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6A3381202F6 for <quic-issues@ietf.org>; Wed, 17 Jul 2019 04:53:32 -0700 (PDT)
Date: Wed, 17 Jul 2019 04:53:31 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1563364411; bh=fGgGx3dMsSUHPo2TrQ5Pvv2mQaCqV186NKqdFaGTJgI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ttmm6j84UPyWlfyCCjoK777eHMmT7E/uVHi+6ZeWoiOrkkXekKqwGcCAVOYnSWlHA axcDYvUz0zHASpn/6nY3lePnO3CZ4J85ovIgdYvq/4sClv5nQHwSSssZxRu7NZRA5J Gcl93Fi4mzP53ZrQxuarI6A5ux/v9y5NeRkXTk3k=
From: Jeremy Lainé <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4T4YROURSSVBIH2KN3HQ7LXEVBMPHAEC7MCA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/commit/cb6828672ebbb3288be99155ae151ed243723421/34335760@github.com>
In-Reply-To: <quicwg/base-drafts/commit/cb6828672ebbb3288be99155ae151ed243723421@github.com>
References: <quicwg/base-drafts/commit/cb6828672ebbb3288be99155ae151ed243723421@github.com>
Subject: Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806) (cb68286)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d2f0c3b56f09_6df83fbcca2cd96016076f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: jlaine
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/cGeFJXiXaMA63qfiA8JFUmqNXYk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jul 2019 11:53:34 -0000
Is this right? It looks like this should be an if/else which still leads to `loss_detection_timer.update` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/commit/cb6828672ebbb3288be99155ae151ed243723421#commitcomment-34335760