IETF Logo Mail Archive

Re: [quicwg/base-drafts] Exception in ECN detection when ACK loss happens (#1555)

ianswett <notifications@github.com> Fri, 13 July 2018 00:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB06E131228 for <quic-issues@ietfa.amsl.com>; Thu, 12 Jul 2018 17:40:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z1K1B9LrOocV for <quic-issues@ietfa.amsl.com>; Thu, 12 Jul 2018 17:39:58 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE7CF131226 for <quic-issues@ietf.org>; Thu, 12 Jul 2018 17:39:58 -0700 (PDT)
Date: Thu, 12 Jul 2018 17:39:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531442397; bh=+ndl98BrFsfMfkAXZjv5XT3vH+QSgkEezKXehj8TiXI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iXk3RePMvwE/TKPae7qF2nRe3JreNQ4dRvWBiLAortRyDn5tztpv2zuHLCg5n9D4s BH08HpPSjVAKvmiDSlRLe82eYyf2GOZfRKzKvv3K4H9jZWE0RMr2IJVNoqCEZ4Dy+l 0o3771ly4149Yuint5uSHM2BrJZaTT6hBTHlXPa0=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab864e43fd479052526d34f2619c1800af6cefcbf392cf00000001175fb6dd92a169ce144fcb80@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1555/review/136875401@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1555@github.com>
References: <quicwg/base-drafts/pull/1555@github.com>
Subject: Re: [quicwg/base-drafts] Exception in ECN detection when ACK loss happens (#1555)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b47f4ddd7605_7ef03f94ec0e0f7c12519"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/c_0ynfUtfSo3DQNN_Hdhq01_THs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2018 00:40:02 -0000

ianswett commented on this pull request.



> @@ -1739,6 +1739,13 @@ network, an endpoint verifies the following when an ACK_ECN frame is received:
 * The increase in ECT(0) and ECT(1) counters MUST be no greater than the number
   of packets newly acknowledged that were sent with the corresponding codepoint.
 
+* If the increase in the ECT(0), ECT(1) and CE counters are greater than the
+  number of newly ACKed packets, and received ACK's smallest acknowledged is

ACKed -> acknowledged
received -> the received

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1555#pullrequestreview-136875401

v2.23.0 | Report a Bug | By Email