IETF Logo Mail Archive

Re: [quicwg/base-drafts] Crisp definition of BLOCKING and friends (#1889)

Nick Banks <notifications@github.com> Fri, 19 October 2018 13:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79272130EE7 for <quic-issues@ietfa.amsl.com>; Fri, 19 Oct 2018 06:50:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.064, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uYDluiRj3SVL for <quic-issues@ietfa.amsl.com>; Fri, 19 Oct 2018 06:50:17 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 21C65130E70 for <quic-issues@ietf.org>; Fri, 19 Oct 2018 06:50:14 -0700 (PDT)
Date: Fri, 19 Oct 2018 06:50:12 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1539957012; bh=/el++N41/uNXdFfMmaXGpEZJMDtDbjXxzL+w1D36sxU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VedMBn8P0Jaok0wBwMjTa9LO74uXmP+no1hlAiXjRkSJ7Cceq0iZ0DzNn+LZfhKgd 5saFI2Kb9e0Wt2yN5E7inxo7pidrRO7f+lLJOKm8h2bUUd5DIvq+C7RaTwQHhYMSX5 hRckb/Eoozt8xG0QQ0hi4L084jL1fb1Xe88N7Fns=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4c8b9be7f0d333176d431f3580e5faa3ebe99b1c92cf0000000117e1a31492a169ce16294480@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1889/review/166531997@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1889@github.com>
References: <quicwg/base-drafts/pull/1889@github.com>
Subject: Re: [quicwg/base-drafts] Crisp definition of BLOCKING and friends (#1889)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bc9e114e16eb_1d123fa7c68d45c015844"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/c_MDYogaadCPLfD_o6m-ewfpSDg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Oct 2018 13:50:19 -0000

nibanks commented on this pull request.



> @@ -4340,8 +4340,9 @@ The STREAM_ID_BLOCKED frame contains a single field.
 
 Stream ID:
 
-: A variable-length integer indicating the highest stream ID that the sender
-  was permitted to open.
+: A variable-length integer indicating the stream ID limit at the time the
+  sender was unable to open new streams.

If we changed it to MAX_STREAM_COUNT, we'd have to use one additional bit from the type to indicate unidirectional/bidirectional, right? To me, my favorite thing (if we made that change) would be that I no longer have to validate if the peer is trying to set my limit on them (i.e. ownership bit).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1889#discussion_r226653712

v2.23.0 | Report a Bug | By Email