IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fragility in ECN counters with lost acks (#1481)

Magnus Westerlund <notifications@github.com> Thu, 12 July 2018 19:49 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9892F130EF1 for <quic-issues@ietfa.amsl.com>; Thu, 12 Jul 2018 12:49:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id osoB_GKKL8sM for <quic-issues@ietfa.amsl.com>; Thu, 12 Jul 2018 12:49:14 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 62BFB130E17 for <quic-issues@ietf.org>; Thu, 12 Jul 2018 12:49:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=RRWdirXnSKUSyq6iU6PJ/MZ4n4A=; b=K84k5bel71GP3L1p yzE4y4p+PzUaUfpny6s9L+i/meLqsgRDfSyCFi3LZt+WWhS+s/LRcwop9XuFunjL T1bdcA5mRoJVMu63m8iMr679bEVEiLpu1ae0BCUTtx2F/x9QpeOS3LzClNzK5m1t toiamXTy85HKOeqaVfNvbl73pBA=
Received: by filter0342p1iad2.sendgrid.net with SMTP id filter0342p1iad2-19989-5B47B0B8-35 2018-07-12 19:49:12.988249684 +0000 UTC
Received: from github-lowworker-89d05ac.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id I3nsuSDORXi2iZSFKCCFRQ for <quic-issues@ietf.org>; Thu, 12 Jul 2018 19:49:12.887 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-89d05ac.cp1-iad.github.net (Postfix) with ESMTP id D6502AE026A for <quic-issues@ietf.org>; Thu, 12 Jul 2018 12:49:12 -0700 (PDT)
Date: Thu, 12 Jul 2018 19:49:13 +0000
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2223c31b24d38a696dbafdb2a024a2d3ba78be3a92cf00000001175f72b892a169ce1406c905@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1481/404629725@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1481@github.com>
References: <quicwg/base-drafts/issues/1481@github.com>
Subject: Re: [quicwg/base-drafts] Fragility in ECN counters with lost acks (#1481)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b47b0b8d3f7e_7a052ae58ff92f5072094"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1Ns0layx9sJyPoVgl6WIIYbMZs3t7J95CIdp A2XqprB7YkaAHY06ZEzaWmf6oU4UnRtgD/FEaxGajNdJaLsgGfoxxMj0MZviHnCsG9wkRCBQpsCjKQ fQky7GmPbo+cjElvHYrgkQXVEIubmRS4kOpMkNO5rSfiDZO/ALrGBTbZPEeeo7Vv/SR9LcjvJ6D77K I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dOoWIVcXQjmnxeyh8H-3dl2lptY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jul 2018 19:49:18 -0000

I have drafted an initial text to resolve this. See PR #1555. I took the simpler way out that if one detects ACK loss one simple skip to do the counter comparisons. That should be less error prone and is something that should happen very seldom. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1481#issuecomment-404629725

v2.23.0 | Report a Bug | By Email