Re: [quicwg/base-drafts] Explicitly allow discard of packets <40 bytes (#2864)

ianswett <notifications@github.com> Tue, 02 July 2019 22:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4541B12012A for <quic-issues@ietfa.amsl.com>; Tue, 2 Jul 2019 15:56:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L1yVtuepumai for <quic-issues@ietfa.amsl.com>; Tue, 2 Jul 2019 15:56:33 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 78023120106 for <quic-issues@ietf.org>; Tue, 2 Jul 2019 15:56:33 -0700 (PDT)
Date: Tue, 02 Jul 2019 15:56:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1562108192; bh=fLna/ZW927g8ihB0OPwqCSDcD2FZME+ZUXScfafDttg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZqK29G2Oa6WpseXFvT0AmY/v0k8l2skKGKNxswoIK+bRWb835ni8uwayALJNl6I9H 5q5mbFx8uq6Mk99J7O9+k/gHhV58f0Ib7pEnXKEfI1ofv6BycFxmWhXjXVB4T2I8zq plJdILNvwrt+v5vm3P3C6supmsOMhc3TkJiWoY1Y=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3R3PC2B4DQXJDOBZ53FEJ2BEVBNHHBXEE5LI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2864/review/257188911@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2864@github.com>
References: <quicwg/base-drafts/pull/2864@github.com>
Subject: Re: [quicwg/base-drafts] Explicitly allow discard of packets <40 bytes (#2864)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d1be12032bec_159d3fdf9c6cd96c302323"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/do40KCw61NGjbGxj2hDuGn1Ylww>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jul 2019 22:56:36 -0000

ianswett requested changes on this pull request.



> @@ -2510,7 +2510,8 @@ Reset in response, which could lead to an infinite exchange.
 An endpoint MUST ensure that every Stateless Reset that it sends is smaller than
 the packet which triggered it, unless it maintains state sufficient to prevent
 looping.  In the event of a loop, this results in packets eventually being too
-small to trigger a response.
+small to trigger a response.  An endpoint MAY choose not to send a Stateless
+Reset in response to a packet that is smaller than 40 bytes.

The existing text was confusing, but I don'd see how this text is relevant to looping?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2864#pullrequestreview-257188911