[quicwg/base-drafts] "Handshake Packet" is Overloaded (#1836)
martinduke <notifications@github.com> Fri, 05 October 2018 16:42 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0E987130E51 for <quic-issues@ietfa.amsl.com>; Fri, 5 Oct 2018 09:42:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4oltJdImBNYR for <quic-issues@ietfa.amsl.com>; Fri, 5 Oct 2018 09:42:28 -0700 (PDT)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DEEB7130DC1 for <quic-issues@ietf.org>; Fri, 5 Oct 2018 09:42:27 -0700 (PDT)
Date: Fri, 05 Oct 2018 09:42:26 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538757747; bh=c3QmUIF/eM26x9U0JhUjlabvcZ4EAitc4hAXf463aEk=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=yW5uO+08mjxS7O6RrrHNPQBXFaAR9V/f9fUGXzkdi4cHuv/Xr0BUCyG/MLTxqaBCy nXFIB7UJTednoOxEVu9/0O4JuAoSeKbGvRQ0OZzL5mu2dtMTP2z7ix59CLRqFHlw8M gDomP5cQKavN2k5NhWJIWY+DWS84RXtkqTt5mBAM=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8b395569242e405089369b972bd362e01039f20992cf0000000117cf567292a169ce15e45ac3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1836@github.com>
Subject: [quicwg/base-drafts] "Handshake Packet" is Overloaded (#1836)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb79472eb6ce_3d4b3f7e6dad45b43713c4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eUsSfVZvb2CttRhAXrIrgOeeYuY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Oct 2018 16:42:31 -0000
In the base drafts I can think of three definitions of handshake packets: 1) Packets of type "handshake" (obviously) 2) Packets with Long Headers (Used to limit server send before address verification), not formally defined as such but confusingly in the "handshake packets" section even though it applies to Initial, Handshake, and (in theory) 1-RTT packets. 3) In the Recovery draft, is_handshake_packets refers to packets with long headers that also contain CRYPTO frames. This isn't a satisfactory state of affairs. I propose we retain #1. For #2, I believe it's sufficient to simply put this somewhere else (I vote for the flow control section) and make it clear that it applies to packets of all types. For #3, I suggest we name it "crypto packets", as this term doesn't exist elsewhere. I don't really care what the name is as long as it's unique. I'm happy to file a PR if no one has any problems with what I've proposed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/1836