[quicwg/base-drafts] b37554: Rework Retry packet

Martin Thomson <martin.thomson@gmail.com> Tue, 31 July 2018 05:13 UTC

Return-Path: <bounce+565321.40f-quic-issues=ietf.org@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B3BDB130E06 for <quic-issues@ietfa.amsl.com>; Mon, 30 Jul 2018 22:13:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.5
X-Spam-Level:
X-Spam-Status: No, score=-0.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1QWOZM87PeNo for <quic-issues@ietfa.amsl.com>; Mon, 30 Jul 2018 22:13:10 -0700 (PDT)
Received: from m69-170.mailgun.net (m69-170.mailgun.net [166.78.69.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE4AA130DF0 for <quic-issues@ietf.org>; Mon, 30 Jul 2018 22:13:09 -0700 (PDT)
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=github.com; q=dns/txt; s=mailo; t=1533013989; h=Content-Transfer-Encoding: Content-Type: Mime-Version: Subject: Message-ID: To: Reply-To: From: Date: Sender; bh=y3r72gxVPTB+OqathzP+zRPMzQoe7505TQWbSYGjL8A=; b=XxKF3X5ceDS1L7sKoZbXhwWd113uqTA1IH01/DtuCQLBG6zpmoIi2s6VGvfovJKZlyXzz+Ru T5XgWXxSaJf6qhVLH+7XSul8CrquAq/oaZjlREZjRVGccWJ7dZ/hgrMc+BDm5k5NiKeAV2DU MNqqtTj0/DPz8MlgQTdxgkrLpB8=
X-Mailgun-Sending-Ip: 166.78.69.170
X-Mailgun-Sid: WyJhNzYyYiIsICJxdWljLWlzc3Vlc0BpZXRmLm9yZyIsICI0MGYiXQ==
Sender: martin.thomson=gmail.com@github.com
Received: from github.com (Unknown [192.30.252.38]) by mxa.mailgun.org with ESMTP id 5b5fefe4.7f3991b15e70-smtp-out-n02; Tue, 31 Jul 2018 05:13:08 -0000 (UTC)
Date: Mon, 30 Jul 2018 22:13:08 -0700
From: Martin Thomson <martin.thomson@gmail.com>
Reply-To: Martin Thomson <martin.thomson@gmail.com>
To: quic-issues@ietf.org
Message-ID: <5b5fefe4a21ec_5bd32acc7fcdaf7060850@hookshot-fe-265448d.cp1-iad.github.net.mail>
Subject: [quicwg/base-drafts] b37554: Rework Retry packet
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="--==_mimepart_5b5fefe4a1de6_5bd32acc7fcdaf70607b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eyBCk35BCy-FcT6h8QrchDs5uro>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 05:13:12 -0000

  Branch: refs/heads/master
  Home:   https://github.com/quicwg/base-drafts
  Commit: b3755446d985d542105628c0a6509328976e89da
      https://github.com/quicwg/base-drafts/commit/b3755446d985d542105628c0a6509328976e89da
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-06-29 (Fri, 29 Jun 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Rework Retry packet

This includes several changes:

* I moved the Retry packet description.  It is more like Version Negotiation than Handshake or Initial, so it made sense to move it up.

* Retry doesn't include a packet number or payload.  Like Version Negotiation, it includes a complete definition.

* As discussed in #1451, this requires a server that might send another Retry to provide a connection ID of at least 8 octets.

* I clarified the description of fields, expanded the pictures, and made some other editorial tweaks.

Open Question: would it make sense to normalize the encoding of Retry and Initial?  The former includes a token without a length (because it's the last piece of the packet), whereas the latter includes a length-prefixed token.  It might be easier to invert the ODCID and token on Retry.  That would make the token processing more consistent.  I'm not sure if we want to consider adding a token to 0-RTT and Handshake packets, but that would fully normalize things.

Closes #1492, #1451.


  Commit: bf3f67597f3315018d348bfcf638d8fb9379ff0f
      https://github.com/quicwg/base-drafts/commit/bf3f67597f3315018d348bfcf638d8fb9379ff0f
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-06-29 (Fri, 29 Jun 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Review comments


  Commit: 55e910f476f56ede4f13ff506378f74a0e488444
      https://github.com/quicwg/base-drafts/commit/55e910f476f56ede4f13ff506378f74a0e488444
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Address various comments


  Commit: fdb837fc8cd9b20486007f377411ff8fb98f1066
      https://github.com/quicwg/base-drafts/commit/fdb837fc8cd9b20486007f377411ff8fb98f1066
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Collapse a few things


  Commit: dd13b0e26724445d20353a8eb382a99edc5734cc
      https://github.com/quicwg/base-drafts/commit/dd13b0e26724445d20353a8eb382a99edc5734cc
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M draft-ietf-quic-tls.md

  Log Message:
  -----------
  Add PN offset calculation adjustment for Initial packet


  Commit: c96058fc6423de0fa332f09cd500b68e1fd5ca36
      https://github.com/quicwg/base-drafts/commit/c96058fc6423de0fa332f09cd500b68e1fd5ca36
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-06 (Fri, 06 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Grammar hard


  Commit: e3756579b43c43b002afa71ce5818341ec5c114b
      https://github.com/quicwg/base-drafts/commit/e3756579b43c43b002afa71ce5818341ec5c114b
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Redo ODCIL encoding.  Closes #1535.


  Commit: 555ae817e5e7fb37dfb1167d08c37c8ecf901dc0
      https://github.com/quicwg/base-drafts/commit/555ae817e5e7fb37dfb1167d08c37c8ecf901dc0
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Tweak language


  Commit: 19174cfecc237a4c7e772a40992631a25a124c6f
      https://github.com/quicwg/base-drafts/commit/19174cfecc237a4c7e772a40992631a25a124c6f
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Grammar fixes, leftover invalid text


  Commit: 21f9ba5250712726f1112695a8d8a168a567c693
      https://github.com/quicwg/base-drafts/commit/21f9ba5250712726f1112695a8d8a168a567c693
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Refine token use and reuse constraints


  Commit: 7d96aa94e314fc26dc4c241865dca8036e842d6f
      https://github.com/quicwg/base-drafts/commit/7d96aa94e314fc26dc4c241865dca8036e842d6f
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-12 (Thu, 12 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  FOUR bits


  Commit: dbc58a158b1bbeb2043d2224e2eba01bc38b6347
      https://github.com/quicwg/base-drafts/commit/dbc58a158b1bbeb2043d2224e2eba01bc38b6347
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-12 (Thu, 12 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  ODCIL will never be <8


  Commit: cd9cdb48daea18b3f9b10e3459df09e833dcad32
      https://github.com/quicwg/base-drafts/commit/cd9cdb48daea18b3f9b10e3459df09e833dcad32
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  a new value


  Commit: 85f58c060fcdec2c26c16c3d0f4d3915c8500a5f
      https://github.com/quicwg/base-drafts/commit/85f58c060fcdec2c26c16c3d0f4d3915c8500a5f
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2018-07-31 (Tue, 31 Jul 2018)

  Changed paths:
    M draft-ietf-quic-tls.md
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Merge pull request #1498 from quicwg/move-retry

Rework Retry packet


Compare: https://github.com/quicwg/base-drafts/compare/231a518591e4...85f58c060fcd
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.