Re: [quicwg/base-drafts] Discuss HTTP/QUIC Connection Closure (#1712)

[Luca Niccolini <[e-mail]>]

lnicco commented on this pull request.



> +the error code HTTP_REQUEST_CANCELLED.  Servers MAY also cancel requests on
+streams below the indicated ID if these requests were not processed.
+
+Requests on Stream IDs less than or equal to the Stream ID in the GOAWAY frame
+might have been processed; their status cannot be known until they are completed
+successfully, reset individually, or the connection terminates.
+
+Servers SHOULD send a GOAWAY frame when the closing of a connection is known
+in advance, even if the advance notice is small, so that the remote peer can
+know whether a stream has been partially processed or not.  For example, if an
+HTTP client sends a POST at the same time that a server closes a QUIC
+connection, the client cannot know if the server started to process that POST
+request if the server does not send a GOAWAY frame to indicate what streams it
+might have acted on.
+
+An endpoint MAY send multiple GOAWAY frames if circumstances change. For

I know this commit is just moving text around, but I wanted to note how the beginning of this paragraph seems to be for the most part the same as in HTTP2 and does not take into consideration that in HQ there is no error code in the GOAWAY frame. So perhaps the "sends GOAWAY without an error code" can be removed ?

In HQ the only reason I can think of for the endpoint to send multiple GOAWAY frames is to first signal the intention to drain the connection, so that the remote endpoint on receipt stops creating new streams, and then after 1RTT (or on confirmation that the GOAWAY was received) the local endpoint can actually stop accepting new streams and seal the last stream ID and send a new GOAWAY frame. The remote endpoint upon receipt can now reset streams it thinks are established but in truth are not, with HTTP_REQUEST_CANCELLED, as explained above. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1712#pullrequestreview-150367939