Re: [quicwg/base-drafts] Forbid Handshake key discarding (#3121)

ianswett <> Fri, 18 October 2019 22:21 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id CEF58120122 for <>; Fri, 18 Oct 2019 15:21:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id 2sngPiutu9q6 for <>; Fri, 18 Oct 2019 15:21:31 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 37FA1120074 for <>; Fri, 18 Oct 2019 15:21:29 -0700 (PDT)
Received: from ( []) by (Postfix) with ESMTP id 9116F96056B for <>; Fri, 18 Oct 2019 15:21:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1571437288; bh=hQ0JOb/t6SjMi2PJGNOYvXnkM9Yj+L2tBoxZ+kAIvos=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zGVwR8sHvMUDTfLmQ6Nw6LdgqecqI7OXYllJ9CQlUTlxNJZuIHxMc6zVD74XUBFi5 xHubbJxbQk0F4+3E7P+rEQMtneoKY7L/uDcMeBeg8ql54qSPCJ0viQWlOnJCVADlPJ fhog7FQMO1bGoF3xgdmsxjxes9ufzyfV6TxuMDZk=
Date: Fri, 18 Oct 2019 15:21:28 -0700
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3121/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Forbid Handshake key discarding (#3121)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5daa3ae881ae3_70f13fca098cd9681043e6"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Fri, 18 Oct 2019 22:21:33 -0000

ianswett approved this pull request.

One suggestion, but I think this is what we agreed to.

> @@ -760,14 +760,8 @@ and ignoring any outstanding Initial packets.
 ### Discarding Handshake Keys
-An endpoint MUST NOT discard its handshake keys until the TLS handshake is
-confirmed ({{handshake-confirmed}}).  An endpoint SHOULD discard its handshake
-keys as soon as it has confirmed the handshake.  Most application protocols
-will send data after the handshake, resulting in acknowledgements that allow
-both endpoints to discard their handshake keys promptly.  Endpoints that do
-not have reason to send immediately after completing the handshake MAY send
-ack-eliciting frames, such as PING, which will cause the handshake to be
-confirmed when they are acknowledged.
+An endpoint MUST NOT discard its handshake keys.  Discarding Handshake keys too
+early can lead to deadlock conditions.

early can lead to the peer never receiving an acknowledgement for Handshake data.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: