Re: [quicwg/base-drafts] loss_detection_timer.update in recovery (#3969)

Kazu Yamamoto <> Tue, 04 August 2020 04:29 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 9C0E53A0B3B for <>; Mon, 3 Aug 2020 21:29:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -0.498
X-Spam-Status: No, score=-0.498 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id f-wFMsyPaH3Z for <>; Mon, 3 Aug 2020 21:29:12 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id A40313A0781 for <>; Mon, 3 Aug 2020 21:29:12 -0700 (PDT)
Received: from ( []) by (Postfix) with ESMTP id F2377E0401 for <>; Mon, 3 Aug 2020 21:29:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1596515351; bh=qzdavu6ex9PCB09/JOce6Gzt7ZW9RpUxsFlP792t1zc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Lb6xI+qqLfW6DvzIOZ7WwAhHc3ReALjmSFC0VwKT3LNhHmJiURKYnfiOYaKdZNY9x LPKqfdtkXRyqkKteV78xxj/oDic3JJhuHkW8bpzXZbovTyFWTJtT49ztxxNhe2pC9A BeyPOc5Odl1JJcSuB181NQ+0bl9g8zgriVNYuJLo=
Date: Mon, 03 Aug 2020 21:29:11 -0700
From: Kazu Yamamoto <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/issues/3969/>
In-Reply-To: <quicwg/base-drafts/issues/>
References: <quicwg/base-drafts/issues/>
Subject: Re: [quicwg/base-drafts] loss_detection_timer.update in recovery (#3969)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f28e417e1ed9_5d3c16f82606f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Tue, 04 Aug 2020 04:29:14 -0000

I understand why `timeout - now()` can be negative. Suppose PTO for Initial is set. `SetLossDetectionTimer` is called even in Handshake but `GetPtoTimeAndSpace` returns Initial in this case. So, `loss_detection_timer.update` called in `SetLossDetectionTimer` *adjusts* the previous timer. It depends on timing (probably in thread programming), the value can be negative.

When I modify my code so that `SetLossDetectionTimer` takes packet space and add some logic, I don't see warning for minus anymore. I don't have a strong opinion to modify the current pseudocode but I'm pointing out this for record.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: