Re: [quicwg/base-drafts] Change illegal PRIORITY frame to a conn error (#2508)

martinduke <notifications@github.com> Sat, 09 March 2019 04:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7391126F72 for <quic-issues@ietfa.amsl.com>; Fri, 8 Mar 2019 20:49:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ruKuPoXOExWX for <quic-issues@ietfa.amsl.com>; Fri, 8 Mar 2019 20:49:38 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5474D124BAA for <quic-issues@ietf.org>; Fri, 8 Mar 2019 20:49:38 -0800 (PST)
Date: Fri, 08 Mar 2019 20:49:37 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1552106977; bh=RZECeo2QMR7PJfUHDS5GZUOXH4Jzti6X3CAJvvKeTas=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=C0XK1PgCt5nPklXXuiAoH/8U/YufqMVCf8mo2xq8wq6zKbVUU9DJ0LyTdGdbkT+L6 3QUHpiqp4/+w2cM+m/8aQRvrzoEmgZpUdTbQhRtsYEDbXViiDTIBnYmm6kk2+A+uuu hYQFG4f7keLm3hKuTQKl5qlsRA2SP8Gj7htyoJNo=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe0ec9ed90d42f58896966ab891f037d67f77b77492cf00000001189b07e192a169ce18f8cd8e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2508/c471145520@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2508@github.com>
References: <quicwg/base-drafts/pull/2508@github.com>
Subject: Re: [quicwg/base-drafts] Change illegal PRIORITY frame to a conn error (#2508)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c8345e13d3c8_3d863ff76d4d45b427687b1"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fzsMfq98oCuPk7rYdq7j-9nyUws>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Mar 2019 04:49:40 -0000

I haven't comprehensively reviewed the draft, but having just implemented the HTTP/3 frame parser, I can say that other UNEXPECTED_FRAME instances are connection errors.

Furthermore, PRIORITY frames can arrive on the control stream. If there were a stream error there it would have to take down the connection anyway.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2508#issuecomment-471145520