Re: [quicwg/base-drafts] QPACK decoder stream buffer grows without bounds (#2999)
Mike Bishop <notifications@github.com> Tue, 03 September 2019 19:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 856D5120805 for <quic-issues@ietfa.amsl.com>; Tue, 3 Sep 2019 12:34:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.455
X-Spam-Level:
X-Spam-Status: No, score=-6.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XR5vjNHOxVYT for <quic-issues@ietfa.amsl.com>; Tue, 3 Sep 2019 12:34:40 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 98598120233 for <quic-issues@ietf.org>; Tue, 3 Sep 2019 12:34:40 -0700 (PDT)
Date: Tue, 03 Sep 2019 12:34:39 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1567539279; bh=ukYJYqopfrfuIhrF0Y6V4YWX8KHlwr5bv1A4U7IO4v0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=sAhan9APcOZ3deEc4+o1ZzlLQhsbxIDLlJJwrBDv8BwAqV1829jbxEOE3IyYFcHw5 0YrEq+EXT2XA/co9EnyH3bw8E/zERGiW8k7YdkXIMTI9cWu1uyFeSD+ya2SVISb8ic UcdroAstk4yL+kDguG/6CNyD0T1NQzsu/VevFdWU=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ5UF4YJ3CEB53DKLF3PQAN7EVBNHHB2D4G5I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2999/527606375@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2999@github.com>
References: <quicwg/base-drafts/issues/2999@github.com>
Subject: Re: [quicwg/base-drafts] QPACK decoder stream buffer grows without bounds (#2999)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d6ec04f81399_31153fc0ed0cd9681105a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hCNpjR4KWeDEFtzo90SA442OZGk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Sep 2019 19:34:53 -0000
Hypothetically, this limit would create a way to force the peer to kill the connection by starving the decoder stream of flow control credit and then cancelling lots of streams. However, the consumer of (and therefore the entity which could fail to read) the decoder stream is the encoder, and the encoder can trivially cause the connection to close by emitting an invalid instruction anyway. That seems fine. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/2999#issuecomment-527606375
- Re: [quicwg/base-drafts] QPACK decoder stream buf… Mike Bishop
- [quicwg/base-drafts] QPACK decoder stream buffer … Tatsuhiro Tsujikawa
- Re: [quicwg/base-drafts] QPACK decoder stream buf… Mike Bishop
- Re: [quicwg/base-drafts] QPACK decoder stream buf… afrind
- Re: [quicwg/base-drafts] QPACK decoder stream buf… Dmitri Tikhonov