IETF Logo Mail Archive

Re: [quicwg/base-drafts] use varints in transport parameters (#1608)

Kazuho Oku <notifications@github.com> Sun, 29 July 2018 23:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 34741130DEA for <quic-issues@ietfa.amsl.com>; Sun, 29 Jul 2018 16:52:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DBhNeLopbB_A for <quic-issues@ietfa.amsl.com>; Sun, 29 Jul 2018 16:52:07 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A2F3D130DCD for <quic-issues@ietf.org>; Sun, 29 Jul 2018 16:52:07 -0700 (PDT)
Date: Sun, 29 Jul 2018 16:52:06 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1532908326; bh=DsO65Ni56FRsRjIM0gG/zIylrJs8Ir+sEhmR/XBqTrw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=P3c6cXwz4kAAtsYuHxLqeY8ho2xrDL8UIVlx3tVQmPxbiV7OBjGxLBLD0BKNKEUar RdZ0uQa3S/OweFItJrV3GhPnhRQlAsGtW7VTMAT4kG4kr5vnGEQMVKZeE5RQT7I6f+ 1ei7RBZleIPfLl5rngp72yTiekcR5jMIdVjxNnZg=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab687fb8b5bd7840625066c2ed96f839bae190c91f92cf000000011776152692a169ce1498f380@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1608/408714923@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1608@github.com>
References: <quicwg/base-drafts/issues/1608@github.com>
Subject: Re: [quicwg/base-drafts] use varints in transport parameters (#1608)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b5e53269f31d_4e03f8dfa6be618585449"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hUN1IDfhkNC4OzS7gAAktRj0dWE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Jul 2018 23:52:09 -0000

I think that it makes sense to use varints for representing the **values** of the TransportParameters (i.e. the values defined in [section 6.6.1 Transport Parameter Definitions](
https://quicwg.org/base-drafts/draft-ietf-quic-transport.html#rfc.section.6.6.1)).

I do not oppose to using varint for TransportParameterId.

OTOH, (I do not necessarily assume that you meant this, but) I would oppose to using varints for QuicVersion, or using varint for representing the size of the blocks (i.e. the length of the block represented using `<x..y>` notation). This is because QuicVersion is a fixed length integer in QUIC as well, and because we do not have a way to express an optional block in QUIC.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1608#issuecomment-408714923

v2.23.0 | Report a Bug | By Email