IETF Logo Mail Archive

Re: [quicwg/base-drafts] Move text on infinite ACK loops (#4859)

Mike Bishop <notifications@github.com> Thu, 01 April 2021 20:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 123363A21E7 for <quic-issues@ietfa.amsl.com>; Thu, 1 Apr 2021 13:17:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AjEWSQ1NpMm0 for <quic-issues@ietfa.amsl.com>; Thu, 1 Apr 2021 13:17:36 -0700 (PDT)
Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB7B83A21EC for <quic-issues@ietf.org>; Thu, 1 Apr 2021 13:17:36 -0700 (PDT)
Received: from github.com (hubbernetes-node-37c7581.ash1-iad.github.net [10.56.25.20]) by smtp.github.com (Postfix) with ESMTPA id BF675840089 for <quic-issues@ietf.org>; Thu, 1 Apr 2021 13:17:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1617308255; bh=6DmbBDMoeVqzc9HK72mJrWdNo2HSuV2zkm7OXb0NjW8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yv4NHDYZQnpPKcx4V79+3NNmCmyOPtjJ+axYUyxy9DTQBKIQWtc2q87jtRh9DHDei H2NpxIDIrgPADlSCxRQcvUJfLxVHkS3q2tOXR7OikF/ttG5WWRvR2jfaFKP28Qyw2d NkwAEJP9gTKgoEgjW0V8BL1nbLBYiZHg/jjyu7y0=
Date: Thu, 01 Apr 2021 13:17:35 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6KU5EBX4XIYMXICMN6OIFV7EVBNHHDEY7AXM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4859/review/626615976@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4859@github.com>
References: <quicwg/base-drafts/pull/4859@github.com>
Subject: Re: [quicwg/base-drafts] Move text on infinite ACK loops (#4859)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_60662a5fbcbc9_53182472494"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hZmH9_iWCwusty4Me1G-sQa1ezg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Apr 2021 20:17:39 -0000

@MikeBishop commented on this pull request.



> @@ -3747,6 +3747,20 @@ which could prevent the connection from ever becoming idle.  Non-ack-eliciting
 packets are eventually acknowledged when the endpoint sends an ACK frame in
 response to other events.
 
+An endpoint that is only sending ACK frames will not receive acknowledgments
+from its peer unless those acknowledgments are included in packets with
+ack-eliciting frames.  An endpoint SHOULD send an ACK frame with other frames
+when there are new ack-eliciting packets to acknowledge.  When only
+non-ack-eliciting packets need to be acknowledged, an endpoint MAY
+choose to not send an ACK frame with outgoing frames until an

```suggestion
choose not to send an ACK frame with outgoing frames until an
```
Split infinitives and all that....

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4859#pullrequestreview-626615976

v2.23.0 | Report a Bug | By Email