IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add an appendix related to packet number decoding. (#1493)

Masakazu Kitajo <notifications@github.com> Thu, 28 June 2018 01:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7819B130E69 for <quic-issues@ietfa.amsl.com>; Wed, 27 Jun 2018 18:00:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DRnGc02PXc1X for <quic-issues@ietfa.amsl.com>; Wed, 27 Jun 2018 18:00:45 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2A33A130E63 for <quic-issues@ietf.org>; Wed, 27 Jun 2018 18:00:45 -0700 (PDT)
Date: Wed, 27 Jun 2018 18:00:44 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530147644; bh=XLuWHXJArKp+dLx2h4kXjgpS+s/xah1zbvR6rke5JWY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=V0z2LVKolfr1PozYnygP9XArHQ4PPeZDzkDQBgfFamV4gt/4W2kgfpgd84Ap/p3jv qJOlGJg4MVKo4/AnTkWFMZ090Mc9TURKD1F25X3eXGobvhIK2F3lG1DBh8L1al1yLH gI/ODTV8PEbOy2e0bvkHR3VyfJ4sf7PladcJdyE8=
From: Masakazu Kitajo <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba34d9f0bc1f361bb3b00633c46ccbe64f5e109f192cf00000001174bf53c92a169ce140d97f3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1493/c400877448@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1493@github.com>
References: <quicwg/base-drafts/pull/1493@github.com>
Subject: Re: [quicwg/base-drafts] Add an appendix related to packet number decoding. (#1493)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b34333c8e380_2ccf3fe767c82f88798d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: maskit
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/iPxLOHM40hlAcAS16BSakxEV-uQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jun 2018 01:00:47 -0000

Although I'm +1 on adding some pseudo code and this code seems nice as an implementation, I'm not sure this is also nice as a pseudo code to help understanding.

Maybe comparing two candidate packet numbers and choosing one from them (like `candidate1 - expected < candidate2 - expected`) is more straightforward approach.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1493#issuecomment-400877448

v2.23.0 | Report a Bug | By Email