IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify ECN counters (#1913)

ianswett <notifications@github.com> Thu, 25 October 2018 14:59 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB005130E6A for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 07:59:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1XIolVDIP6KS for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 07:59:42 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 96246130E5A for <quic-issues@ietf.org>; Thu, 25 Oct 2018 07:59:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=xrWr0V0FSVL7G5g4n5qomw6kzSM=; b=IjbwizCALh/gV3p5 NMUvQU2QlHJY9p1Fnxcijx/5apLWeicZBMfnD6zySnjV5X9XfLE228weTbQ2aN52 8WhvLgl6rkmnJKbbVmFB6xGSbPdUx1qws7vCQ5Ygctth3ai5+IDndLf/StVBmzuQ OJCvQAzpAjmdvJhz0jVOmtc7Ywg=
Received: by filter1607p1mdw1.sendgrid.net with SMTP id filter1607p1mdw1-19061-5BD1DA5D-24 2018-10-25 14:59:41.553632274 +0000 UTC m=+576391.262647797
Received: from github-lowworker-dc5ea3e.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0011p1iad2.sendgrid.net (SG) with ESMTP id 25AOBEzAT8GagGjzZ3rugQ for <quic-issues@ietf.org>; Thu, 25 Oct 2018 14:59:41.437 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dc5ea3e.cp1-iad.github.net (Postfix) with ESMTP id 64CA226004D for <quic-issues@ietf.org>; Thu, 25 Oct 2018 07:59:41 -0700 (PDT)
Date: Thu, 25 Oct 2018 14:59:41 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab582ea6601ba4372705ff662f47c563412d4f3e3492cf0000000117e99c5d92a169ce1647433c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1913/review/168428171@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1913@github.com>
References: <quicwg/base-drafts/pull/1913@github.com>
Subject: Re: [quicwg/base-drafts] Clarify ECN counters (#1913)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd1da5d633ea_21b93ffa530d45c0245510"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2cTV+R4Rf1Ndm4W9PmI54RQglBQb86p5S0cT Pd1Y533Zue/JsGleSFvCnJJXckgFdm9AVVLa9J7fyQNPBYLEt9B3cQoVoaBZo1jM4e6fWliv477pqM T4kU9alDkM8M4bkKDCJ546nYibBC5EXi9dsfTJ81pxzwmvsB1VVC6ITrtGv1aZhYzuqvS+M78KY3fF A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jT3vb_h9E6WFEuHxonxnxrfErDw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 14:59:45 -0000

ianswett approved this pull request.



> -to received ECN codepoints, it acknowledges received packets per
-{{processing-and-ack}} with an ACK frame.
+If an endpoint receives a QUIC packet without an ECT or CE codepoint, it
+responds per {{processing-and-ack}} with an ACK frame without increasing any ECN
+counters.  Similarly, if an endpoint does not have access to received ECN
+codepoints, it does not increase ECN counters.
+
+Coalesced packets (see {{packet-coalesce}}) mean that several packets can share
+the same IP header.  ECN counters count each QUIC packet, not the enclosing IP
+packet or UDP datagram.
+
+Each packet number space maintains separate acknowledgement state and separate
+ECN counters.  For example, if one each of an Initial, 0-RTT, Handshake, and
+1-RTT QUIC packet are coalesced, the corresponding counters for the Initial and
+Handshake packet number space will be incremented by one and the counters for
+the 1-RTT packet number space will be increased by two.

Oh, well that's weird.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1913#pullrequestreview-168428171

v2.23.0 | Report a Bug | By Email